Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move defaultconfig in plugins to this.yaml #595

Open
6 tasks
smarchint opened this issue Sep 14, 2022 Discussed in #501 · 0 comments
Open
6 tasks

move defaultconfig in plugins to this.yaml #595

smarchint opened this issue Sep 14, 2022 Discussed in #501 · 0 comments
Assignees

Comments

@smarchint
Copy link
Member

Discussed in #501

Originally posted by smarch-int August 8, 2022
Currently we are limited to override single plugin config using this.yaml.
This limitation needs to be addressed by allowing multiple plugin configs to be merged into respective jobs.

Description
Based on the above discussion, the static default configs in the plugins can be provided in the this.yaml spec in the project.
They being static implies that they don't change at job level. This can be defined in this.yaml.
This eliminates the need to explicitly define them in the plugins thereby simplifying the interfaces and codebase.

Acceptance Criteria

  • this.yaml to support config for multiple job types.
  • static config for the jobs should be inferred from this.yaml rather than plugins.
  • job execution should remain unaffected due to this change.

Tech Details

  • this.yaml to implement project spec rather than job spec.
  • Remove DefaultConfig from plugin interface and thereby all the binary implementations of plugins.
  • Infer default configs from this.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant