Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React PDF Viewer Zoom Plugin - Shortcuts are not working #1731

Open
adnan-muhammadi opened this issue Feb 22, 2024 · 0 comments
Open

React PDF Viewer Zoom Plugin - Shortcuts are not working #1731

adnan-muhammadi opened this issue Feb 22, 2024 · 0 comments

Comments

@adnan-muhammadi
Copy link

DOING Ctrl +/-:

  1. Both shortcuts are not working. Instead window is getting zoomed in/out.
  2. But when I open thumbnails in default layout and try, Zoom out is working but not Zoom in.

DOING Ctrl +/- by focusing in current page input field:

  1. Zoom out (Ctrl -) is working but not Zoom in (Ctrl +).
  2. And It’s not supporting Cmd +/- on Mac.

DOING Ctrl + Wheel:

  1. Both Zoom in/out are working on Mac (But on windows, Zooming is getting reset 0% and after that it’s not responsive).
  2. And it’s not supporting Cmd + Wheel on Mac.
  3. You can easily reproduce these issues on both Mac and Windows.

EXPECTED BEHAVIOUR:
When user clicks on PDF and using zooming shortcuts, it should work as expected without affecting window scale. And it's a bad UX to make user click on input field and then use shortcuts right.

Reg Search Plugin Shortcuts:

Zoom.-.Shortcuts.are.not.working.Issue.1704.react-pdf-viewer_react-pdf-viewer.mov

I see it's working fine in default layout. But we are using custom layout with left aligned sidebar. Initially thumbnails are getting rendered in sidebar. So how do I know when user using Ctrl F shortcut to open search bar, I don't find any callback to toggle search bar? Or I should handle this event manually at top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant