Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with recharts 2.8.0 #30

Open
Huararanga opened this issue Sep 21, 2023 · 4 comments
Open

Does not work with recharts 2.8.0 #30

Huararanga opened this issue Sep 21, 2023 · 4 comments

Comments

@Huararanga
Copy link

Hello, it seems this plugin does not work anymore with recharts 2.8.0. The paths inside node_modules/recharts are different. The plugin expects sources in recharts\src\index.ts but 2.8.0 has only es6,lib,types,umd directories inside node_modules/recharts

@ckifer
Copy link
Member

ckifer commented Sep 21, 2023

Seems like it hasn't worked for a while before that change as well #25

This repo isn't really maintained as it was created before I came onto recharts.

We removed the untranspiled src from recharts output because it didn't make sense that anyone should be using it (generally you don't publish TS files).

Instead there are plans to reduce bundle size (such as using individual lodash libraries instead of the whole thing).

I also don't have publish permissions here so I couldn't fix it anyways I guess

@Huararanga
Copy link
Author

I see. Maybe it will be better to update docs in this project? Unmaintained. It does not work since recharts version ...?
Maybe we have to also update this Getting Started docs, because it sends people to the babel-plugin-recharts, which does not work.

image

@ckifer
Copy link
Member

ckifer commented Sep 22, 2023

Sounds good, feel free to open some PRs if you have a chance

@ckifer
Copy link
Member

ckifer commented Sep 22, 2023

Updated the README in 77c3cce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants