Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niceTicks of Infinity domains are wrong #9

Open
puemos opened this issue Oct 10, 2018 · 1 comment
Open

niceTicks of Infinity domains are wrong #9

puemos opened this issue Oct 10, 2018 · 1 comment

Comments

@puemos
Copy link

puemos commented Oct 10, 2018

5 ticks between (-Infinity, Infinity) are not [Infinity, Infinity, Infinity, Infinity, -Infinity]

  "domain": [
    Infinity,
    -Infinity
  ]

  "niceTicks": [
    Infinity,
    Infinity,
    Infinity,
    Infinity,
    -Infinity
  ]

this change is breaking that feature: recharts/recharts#1509

Full axis object:

{
  "allowDataOverflow": false,
  "allowDecimals": true,
  "allowDuplicatedCategory": true,
  "axisLine": false,
  "axisType": "yAxis",
  "bandSize": 0,
  "categoricalDomain": undefined,
  "domain": [
    Infinity,
    -Infinity
  ],
  "duplicateDomain": undefined,
  "height": 356,
  "hide": false,
  "isCategorial": false,
  "label": false,
  "layout": "horizontal",
  "mirror": false,
  "niceTicks": [
    Infinity,
    Infinity,
    Infinity,
    Infinity,
    -Infinity
  ],
  "orientation": "left",
  "originalDomain": [
    "auto",
    "auto"
  ],
  "padding": {
    "top": 0,
    "bottom": 0
  },
  "realScaleType": "linear",
  "reversed": false,
  "scale": " ƒ scale(x)",
  "tick": "",
  "tickCount": 5,
  "tickFormatter": "ƒ (v)",
  "tickLine": false,
  "type": "number",
  "width": 31.796875,
  "x": 0,
  "y": 30,
  "yAxisId": "1"
}
@puemos puemos changed the title niceTick of Ininity domain is wrong niceTicks of Infinity domains are wrong Oct 10, 2018
@puemos
Copy link
Author

puemos commented Oct 15, 2018

any updates? @xile611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant