Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRs from non-organization members fail due to missing GITHUB_TOKEN variable. #153

Open
jmalloc opened this issue Feb 10, 2018 · 0 comments
Open

PRs from non-organization members fail due to missing GITHUB_TOKEN variable. #153

jmalloc opened this issue Feb 10, 2018 · 0 comments

Comments

@jmalloc
Copy link
Member

jmalloc commented Feb 10, 2018

Travis CI (for obvious reasons) does not define encrypted variables when building a PR from a non-member.

The GITHUB_TOKEN variable is only used to avoid GitHub API rate-limiting affecting Composer's ability to install dependencies.

The build process needs to be changed to use composer --prefer-source ... when GITHUB_TOKEN is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmalloc