Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support Python 3.12 #2097

Open
daviddavo opened this issue May 14, 2024 · 2 comments
Open

[FEATURE] Support Python 3.12 #2097

daviddavo opened this issue May 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@daviddavo
Copy link
Collaborator

I know you just updated it to support Python 3.11, but Manjaro or Ubuntu now use Python3.12 by default.

@daviddavo daviddavo added the enhancement New feature or request label May 14, 2024
miguelgfierro added a commit that referenced this issue May 15, 2024
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
miguelgfierro added a commit that referenced this issue May 15, 2024
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@miguelgfierro
Copy link
Collaborator

let's try, this can be as simple as changing a few lines of code, or we might need to fix many dependencies.

@miguelgfierro
Copy link
Collaborator

Issue with Cornac:

2024-05-15T05:14:26: Collecting cornac<2,>=1.15.2 (from recommenders[dev,gpu]@ git+https://github.com/recommenders-team/recommenders.git@809a1d39c3e4bdab72aa56ee80d9eb79413ac29d->-r /azureml-environment-setup/condaenv.8fr4a5nk.requirements.txt (line 3))
2024-05-15T05:14:26:   Downloading cornac-1.18.0.tar.gz (5.8 MB)
2024-05-15T05:14:26:      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB 76.2 MB/s eta 0:00:00
2024-05-15T05:14:26:   Preparing metadata (setup.py): started
2024-05-15T05:14:26:   Preparing metadata (setup.py): finished with status 'error'

2024-05-15T05:14:26: failed
2024-05-15T05:14:26: Pip subprocess error:
2024-05-15T05:14:26:   Running command git clone --filter=blob:none --quiet https://github.com/recommenders-team/recommenders.git /tmp/pip-install-va67dnkb/recommenders_830bb823f0204ab9ae042e7d5057b430
2024-05-15T05:14:26:   Running command git rev-parse -q --verify 'sha^809a1d39c3e4bdab72aa56ee80d9eb79413ac29d'
2024-05-15T05:14:26:   Running command git fetch -q https://github.com/recommenders-team/recommenders.git 809a1d39c3e4bdab72aa56ee80d9eb79413ac29d
2024-05-15T05:14:26:   Running command git checkout -q 809a1d39c3e4bdab72aa56ee80d9eb79413ac29d
2024-05-15T05:14:26:   error: subprocess-exited-with-error
2024-05-15T05:14:26:   
2024-05-15T05:14:26:   √ó python setup.py egg_info did not run successfully.
2024-05-15T05:14:26:   │ exit code: 1
2024-05-15T05:14:26:   ╰─> [2 lines of output]
2024-05-15T05:14:26:       We need some dependencies to build Cornac.
2024-05-15T05:14:26:       Run: pip3 install Cython numpy scipy
2024-05-15T05:14:26:       [end of output]
2024-05-15T05:14:26:   
2024-05-15T05:14:26:   note: This error originates from a subprocess, and is likely not a problem with pip.
2024-05-15T05:14:26: error: metadata-generation-failed

2024-05-15T05:14:26: √ó Encountered error while generating package metadata.
2024-05-15T05:14:26: ╰─> See above for output.

2024-05-15T05:14:26: note: This is an issue with the package mentioned above, not pip.
2024-05-15T05:14:26: hint: See above for details.
2024-05-15T05:14:26: CondaEnvException: Pip failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants