Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultClientResources.dnsResolver(DnsResolver resolver) should be marked as deprecated. #2854

Closed
yfwz100 opened this issue May 14, 2024 · 0 comments · Fixed by #2855
Closed

Comments

@yfwz100
Copy link
Contributor

yfwz100 commented May 14, 2024

Just like definitions at its interface:

/**
* Sets the {@link DnsResolver} that is used to resolve hostnames to {@link java.net.InetAddress}. Defaults to
* {@link DnsResolvers#UNRESOLVED} to use netty's {@link AddressResolverGroup}.
*
* @param dnsResolver the DNS resolver, must not be {@code null}.
* @return {@code this} {@link Builder}.
* @since 4.3
* @deprecated since 6.1. Configure {@link AddressResolverGroup} instead.
*/
@Deprecated
Builder dnsResolver(DnsResolver dnsResolver);

The implementation method should be marked as deprecated to inform users to use the new settings.

public Builder dnsResolver(DnsResolver dnsResolver) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant