restore-file: GraphQL:A path was requested for deletion which does not exist as of commit oid 4ec33cf263e0a086bffb40f15b39a7de3c5044b8

[govindrai]

Description

Error: GraphQL:
A path was requested for deletion which does not exist as of commit oid `4ec33cf263e0a086bffb40f15b39a7de3c5044b8`
    at v4uncached (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/refined-github.js:4392:60)
    at async chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/refined-github.js:8471:11
    at async showToast (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/refined-github.js:5378:40)
    at async HTMLHtmlElement.handleClick (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/assets/refined-github.js:8454:9)

How to replicate the issue + URL

I had a large PR (270 files). I discarded changes on two files. It worked beautifully. Upon restoring my third file, I started getting this error. A this point I had to do the discards manually via git. This is a private repo, so I will try to create a public scenario for this.

Extension version

24.3.20

Browser(s) used

Chrome Version 123.0.6312.59 (Official Build) (arm64)

[fregante]

I think this happens when you delete multiple files in a row. Refreshing the page should work

[govindrai]

I tried that multiple times, Even tried to clear cache/exit browser. It would always give the same error.

[fregante]

This is likely a caching issue, all of our API calls are cached until the next page refresh. If that doesn't do it, it's likely that GitHub is also caching the request.

refined-github/source/features/restore-file.tsx

Line 17 in c8902e5

const response = await api.v3(`compare/${base.relative}...${head.relative}`);

We should either:

• create a v3uncached method like we do for v4:

  refined-github/source/github-helpers/api.ts

  Line 150 in c8902e5

  export const v4uncached = async (

• add a cache buster

I think the latter is easier and safer, if the caching issue is actually on GitHub's side