Markdown paragraph handling is broken

[SebastianStehle]

Summary

I think the markdown paragraph handling is broken right now. Because markdown and html in remirror handle paragraphs differently.

Steps to reproduce

Lets consider a very simple markdown example:

a

b
c

In the editor this is represented as

<p>a</p>
<p></p>
<p>b</p>
<p>c</p>

But in markdown these are 3 paragraphs, so after markdown to html conversion, this would be:

<p>a</p>
<p>b**\n**
c</p>

Therefore both conversions are actually wrong in this context.

Expected results

The markdown output should be the same as the markdown input.

Actual results

Possible Solution

I have fixed it with a custom conversion:

const turnDownService = new TurndownService();

turnDownService.addRule('paragraph2', {
    filter: 'p',
    replacement: content => {
        return `${content}\n`;
    }
});

marked.use({
    renderer: {
        paragraph: (text: string) => {
            const parts = text.split('\n');

            return parts.map(p => `<p>${p}</p>\n`).join('') + EMPTY_LINE;
        }
    }
});

const EMPTY_LINE = '<p></p>\n';

export function htmlToMarkdown(html: string) {
    return turnDownService.turndown(html);
}

export function markdownToHtml(markdown: string): string {
    let html = marked(markdown, { gfm: true });

    if (html.endsWith(EMPTY_LINE)) {
        html = html.substring(0, html.length - EMPTY_LINE.length);
    }

    return html;
}

Screenshot(s)

[SebastianStehle]

Sorry, I have to revert my opinion here. I think the main problem here, is that paragraphs don't have a padding. Therefore my users did not understood that there is actually a new paragraph.