Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkExtension EditDialog Storybook story doesn't allow opening editor #2215

Open
cianmm opened this issue Nov 24, 2023 · 1 comment
Open
Labels
type: bug 🪲 Something isn't working

Comments

@cianmm
Copy link

cianmm commented Nov 24, 2023

Summary

The EditDialog story documenting the LinkExtension doesn't allow opening the editor input when expected.

Steps to reproduce

  1. Open the EditDialog story
  2. Click on the underlined "link" text to edit the link
  3. Note that the link editor doesn't appear

Expected results

Expected results are that the link editor appears

Actual results

The link editor does not appear

Possible Solution

Some searching on the Discord channel suggests that this is down to a bug in FloatingWrapper - the edit input appears when you remove the renderOutsideEditor={false} prop from FloatingWrapper, but this then has other implications like the input area getting hidden by the edge of the contenteditable area.

I've noticed that this behaviour doesn't occur if you don't attempt to place autofocus on the input - but then there's no way to select the input field.

Screenshot(s)

Kapture 2023-11-24 at 10 52 25

@cianmm cianmm added the type: bug 🪲 Something isn't working label Nov 24, 2023
@shlroland
Copy link
Contributor

Duplicate of #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants