You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
config.fadeout_audio is not applied on play sound or stop sound statements, since execute_play_sound executes renpy.sound.play with 0 if no fadeout is supplied, instead of instead of None, causing the config.fadeout_audio to not be applied.
This happens on both play and stop statements.
The play music, stop music and generic play and stop statements WILL default to None instead of 0, so it's not an issue there.
(I beleive this also applies to the respective queue statements)
Related, when rolling back, if audio in the middle of playing, it just cuts off with no fadeout applied, even if one was supplied in the statement (regardless of if it was a play sound or generic play), causing "clicking."
The text was updated successfully, but these errors were encountered:
colinharvie
changed the title
config.fadeout_audio not applied with play/stop statements
config.fadeout_audio not applied with play sound/stop sound statements
May 4, 2024
I think for rollback it makes sense because if the fadeout was a high value, for example 3 seconds, that could be pretty jarring to have the rollback applying that long fadeout. Maybe for rollback the fadeout could be replaced by the config.fadeout_audio value or even the shortest hard value that prevents the clicking to occur? Just some thoughts, don't know if there are other limitations to how rollback stop sound though.
config.fadeout_audio is not applied on
play sound
orstop sound
statements, sinceexecute_play_sound
executesrenpy.sound.play
with0
if no fadeout is supplied, instead of instead ofNone
, causing the config.fadeout_audio to not be applied.This happens on both
play
andstop
statements.The
play music
,stop music
and genericplay
andstop
statements WILL default toNone
instead of 0, so it's not an issue there.(I beleive this also applies to the respective
queue
statements)Related, when rolling back, if audio in the middle of playing, it just cuts off with no fadeout applied, even if one was supplied in the statement (regardless of if it was a
play sound
or genericplay
), causing "clicking."The text was updated successfully, but these errors were encountered: