Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.fadeout_audio not applied with play sound/stop sound statements #5497

Closed
colinharvie opened this issue May 4, 2024 · 1 comment
Closed

Comments

@colinharvie
Copy link

colinharvie commented May 4, 2024

config.fadeout_audio is not applied on play sound or stop sound statements, since execute_play_sound executes renpy.sound.play with 0 if no fadeout is supplied, instead of instead of None, causing the config.fadeout_audio to not be applied.

This happens on both play and stop statements.
The play music, stop music and generic play and stop statements WILL default to None instead of 0, so it's not an issue there.

(I beleive this also applies to the respective queue statements)

Related, when rolling back, if audio in the middle of playing, it just cuts off with no fadeout applied, even if one was supplied in the statement (regardless of if it was a play sound or generic play), causing "clicking."

@colinharvie colinharvie changed the title config.fadeout_audio not applied with play/stop statements config.fadeout_audio not applied with play sound/stop sound statements May 4, 2024
@bober-gith
Copy link

I think for rollback it makes sense because if the fadeout was a high value, for example 3 seconds, that could be pretty jarring to have the rollback applying that long fadeout. Maybe for rollback the fadeout could be replaced by the config.fadeout_audio value or even the shortest hard value that prevents the clicking to occur? Just some thoughts, don't know if there are other limitations to how rollback stop sound though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants