Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ren'Py Launcher does not contain accurate mapping for a bold font #5506

Closed
EtchJetty opened this issue May 11, 2024 · 1 comment
Closed

Ren'Py Launcher does not contain accurate mapping for a bold font #5506

EtchJetty opened this issue May 11, 2024 · 1 comment

Comments

@EtchJetty
Copy link

The Ren'Py launcher contains one notable instance of a bolded version of Roboto, when viewing the version number. However, this usage does not contain accurate font mapping, and thus looks strange.
image
(Above: The default look of the launcher.)
image
(Above: The font mapping fixed by using config.font_replacement_map to accurately assign the bold font to Roboto.)

The bolded line in question is in about.rpy in the launcher project. Below is my modified code that fixes the issue.

screen about:

    $ version = renpy.version()

    frame:
        style_group "l"
        style "l_root"

        window:
            xfill True

            has vbox xfill True

            add "images/logo.png" xalign 0.5 yoffset -5

            null height 15

            text _("[version!q]") xalign 0.5 bold True font "Roboto-Light.ttf"

            null height 20

            textbutton _("View license") action interface.OpenLicense() xalign 0.5

    textbutton _("Return") action Jump("front_page") style "l_left_button"

label about:
    call screen about

init python:
    config.font_replacement_map["Roboto-Light.ttf", True, False] = ("Roboto-Bold.ttf", False, False)

The project does not currently come shipped with Roboto Bold.

@renpytom
Copy link
Member

I don't think it's worth shipping a new font file for one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants