Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation not permitted in rename of directory with children on windows #174

Open
samlhuillier opened this issue Apr 1, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@samlhuillier
Copy link
Collaborator

Screenshot 2024-03-30 at 13 52 49

The above error happens when a user tries to rename a directory on Windows that has children in it. I suspect this is because Reor is locking the files and we need to do something to unlock/unwatch the files when doing the rename operation. More research on this is required though

@samlhuillier samlhuillier added the good first issue Good for newcomers label Apr 1, 2024
@milaiwi
Copy link
Contributor

milaiwi commented May 7, 2024

I'll go ahead and take a look and see what I can get done on this!

@milaiwi
Copy link
Contributor

milaiwi commented May 9, 2024

I went ahead and made a pull request for this. Seems like windows does not allow rename operations when the file is open, and in this case that required unwatching the vault. I simply checked if the user was running on a windows environment and did the necessary steps. Let me know if this is aligned with what you were thinking or some issues that you think this could allow. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants