Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show note name in related notes sidebar and search results #189

Open
samlhuillier opened this issue Apr 8, 2024 · 3 comments
Open

Show note name in related notes sidebar and search results #189

samlhuillier opened this issue Apr 8, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@samlhuillier
Copy link
Collaborator

It would be nice to see which note a chunk that has been matched as similar belongs to. To do this, the react code in DBResultPreview.tsx should be modified: there is one component for similar sidebar results DBResultPreview and another for search results DBSearchPreview.

@samlhuillier samlhuillier added the good first issue Good for newcomers label Apr 8, 2024
@milaiwi
Copy link
Contributor

milaiwi commented May 6, 2024

Are you saying you'd want to see the path of the chunk that pops up in the related notes sidebar or just the name of the file? If it's the path, should it be relative or absolute?

@samlhuillier
Copy link
Collaborator Author

It would just be either the filename I think. We could think about a relative path but given the limited screen estate, filename would be the best imo. Would love to see a contribution here! Let me know if you're interested, very happy to help out & review any PRs :)

@milaiwi
Copy link
Contributor

milaiwi commented May 6, 2024

Thanks for the response! I made a PR for what I believe this issue was trying to do. I couldn't find information for how the commit message should look so let me know if I need to change anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants