Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed TileIds after drag #10

Open
tosti007 opened this issue Jul 5, 2023 · 0 comments
Open

Changed TileIds after drag #10

tosti007 opened this issue Jul 5, 2023 · 0 comments

Comments

@tosti007
Copy link
Contributor

tosti007 commented Jul 5, 2023

When inserting a new Pane into Tiles, it returns a new TileId. The behavior I'd expect is for this TileId to consistently refer to the same Pane throughout the lifetime of the Tree.

However, this seems this is not the case; when a e.g. Tabs container with two Panes is changed into a Horizontal Container, my first Pane's TileId refers to the Horitonzal Container in which the Pane's TileId is stored.

Would it be possible to keep current TileIds always refer to the same Tile? Not only would this remove the need to manually keep track of which CustomId belongs to which Pane, it would also fit (atleast in my opinion) the mental model of a TileId better.

I'm also fine with implementing it myself and saw the insert function, but I'm unsure whether that's the correct place, so would like some small pointers for it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant