{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":285304,"defaultBranch":"master","name":"reviewboard","ownerLogin":"reviewboard","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-08-22T21:39:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/118199?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1704306130.0","currentOid":""},"activityList":{"items":[{"before":"f7f3dd7af6fefea6b9aa0c787876d8e22226c43d","after":"d31276d9a9cafa699e776814e4013d3736ebcc69","ref":"refs/heads/release-7.x","pushedAt":"2024-05-31T21:13:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Update the Review Board logo URL that we suggest to upload to MS Teams in the docs.\n\nWhen setting up a Microsoft Teams integration, admins need to create an\nincoming WebHook via the Microsoft Teams app. When creating the WebHook, you\nhave the ability to upload a picture to associate with all messages coming\nfrom the WebHook (basically an avatar).\n\nSince we don't have control over this, we offer a link to a Review Board logo\nin our docs that admins can upload. This logo differs from our normal logo by\nbeing centered, so that it looks nice in the rounded crop that most chat\napplications use for avatars. We recently added this centered logo to our\nCDN, so this updates the docs to use the right URL for the centered logo.\n\nTesting Done:\nAccessed the URL and made sure it lead to the centered logo.\n\nReviewed at https://reviews.reviewboard.org/r/13916/","shortMessageHtmlLink":"Update the Review Board logo URL that we suggest to upload to MS Team…"}},{"before":"e48193851d9253706d3d770ba21cfde7ba64ac3c","after":"f7f3dd7af6fefea6b9aa0c787876d8e22226c43d","ref":"refs/heads/release-7.x","pushedAt":"2024-05-30T17:09:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Add more default columns to the base review request datagrid.\n\nThis adds the Ship It/Issue counts and New Updates columns to the defaults\nfor the base review request datagrid, which is used for the All Review Requests\npage. I debated adding the My Comments column too but decided against it.\nI felt that it was too personal and that the All Review Requests page should\ndefault to just general information instead.\n\nI also audited the columns we have for the dashboard.\n\nTesting Done:\n- Saw the new columns added to the All Review Requests page (while logged in\nand logged out)\n- Saw that the columns on the dashboard appeared as normal\n- Ran unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13909/","shortMessageHtmlLink":"Add more default columns to the base review request datagrid."}},{"before":"b11f9001e33d52881998f5eb1497354f1e5aac2c","after":"e48193851d9253706d3d770ba21cfde7ba64ac3c","ref":"refs/heads/release-7.x","pushedAt":"2024-05-30T07:36:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Convert the review request field changes to modern CSS components.\n\nThe lists of changed fields on a \"review request changed\" box was\nancient, with spacing and font size inconsistencies, mobile issues, no\naccessibility affordances, and some regressions with recent styling\nchanges.\n\nThis has been redone, as a sort of first pass that we can build upon in\nthe future. We now have two new components we can use:\n\n* `rb-c-review-request-changed-fields`: The container for the entire\n  list of changed fields in the entry box, managing overall layout and\n  the styling for inner value types.\n\n* `rb-c-review-request-changed-value`: An old/new diff display for a\n  single simple field value, such as Branch, Summary, or Depends On.\n\nThe `rb-c-review-request-changed-fields` component is a definition list\nconsisting of field names and their value changes. It uses CSS grid to\ndo the layout, in a responsive manner. Subgrids are employed when\nsupported by the browser in order to help all fields line up correctly\n(without it, we use a minimum width to achieve a similar effect).\n\nThere's now one of these lists instead of many, which can help with\nnavigating using assistive technologies. We also make use of ARIA labels\nthroughout this.\n\n`rb-c-review-request-changed-value` works as the old field changes did\nbefore, but is slightly polished in that it's now less boxy, employing a\nsoft rounded border.\n\nThe changed fields component optimistically aligns the labels and values\nwith a baseline. This works great for the changed value component and\nother simple text-based value representations. However, in an effort to\nproperly align things, special rules for certain value components are\nadded. This gives us alignment for diffed text displays, file attachment\nthumbnails, and the commits list.\n\nField changes were made to aid in this and to help with consistency:\n\n* File attachments now have a parent container that we can set to be a\n  flexbox.\n* Status now says \"Completed\" instead of \"Closed (submitted)\".\n\nSome fields (namely file attachment captions) still need a lot of love,\nbut that's for another release.\n\nThe overall presentation, while resembling what we had before, is now\nmuch more polished, and will be easier to work with going forward.\n\nTesting Done:\nTested in Chrome and Firefox in light and dark modes.\n\nTested with and without subgrid support (by altering the name checked\nby `@support`), and on mobile. Verified the presentation was correct\nin each case.\n\nTested every field type in all the above cases.\n\nReviewed at https://reviews.reviewboard.org/r/13907/","shortMessageHtmlLink":"Convert the review request field changes to modern CSS components."}},{"before":"9b94626ceba1c23db6dea19b70c95ead07ce2183","after":"b11f9001e33d52881998f5eb1497354f1e5aac2c","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T23:02:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Consolidate review request UI CSS imports to an index.less.\n\nThe files in `css/ui/review-request/` and `css/ui/reviews/` were being\nimported into the bundle individually, which gave us two paths to deal\nwith any time we wanted to add a new file.\n\nWe now provide `index.less` files in both directories, which contain the\nimports for that directory, giving the bundle one place exactly to\nimport from.\n\nThere are plenty of remaining problems with our CSS directory layout,\nbut those are for another time.\n\nTesting Done:\nSuccessfully built the CSS.\n\nReviewed at https://reviews.reviewboard.org/r/13904/","shortMessageHtmlLink":"Consolidate review request UI CSS imports to an index.less."}},{"before":"c92cbf8f1b0a3d70b67636a22bad490ebd4b8488","after":"9b94626ceba1c23db6dea19b70c95ead07ce2183","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T23:00:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix a regressed test for the text Review UI.\n\nThe recent change to the tabs for the text Review UI regressed one of\nour js-tests. This change fixes it up for the new element classes.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13910/","shortMessageHtmlLink":"Fix a regressed test for the text Review UI."}},{"before":"84c4fe93c65d0bbf49e3199c3c9ebfd5d0f05bae","after":"c92cbf8f1b0a3d70b67636a22bad490ebd4b8488","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T22:59:52.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update rb-c-alert to use ink-c-alert's visuals.\n\nWe have code that uses `rb-c-alert`, and will continue to through\nrelease. To help keep things looking consistent, this change updates the\ncolors and the icons to match the visuals of `ink-c-alert`.\n\nTesting Done:\nTested all alert types in light and dark mode (initially as part of the\ndiff file notice change, before a new approach was taken), and verified\nthat the right icons and colors were used.\n\nReviewed at https://reviews.reviewboard.org/r/13903/","shortMessageHtmlLink":"Update rb-c-alert to use ink-c-alert's visuals."}},{"before":"7884d78320ad2f9d8ab7ab893cbc739f5c8f9531","after":"84c4fe93c65d0bbf49e3199c3c9ebfd5d0f05bae","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T06:13:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix over-eager deletion with drafts.\n\nWhen I added change descriptions and diffsets to the draft deletion\nhandler, I wasn't thinking about how we delete the draft after\npublishing it. In that case, we've assigned the change description to\nthe review request, and assigned the diffset to the history, but we\nhaven't cleared them from the draft object. We were therefore deleting\nthe data right after we published it.\n\nThis change fixes that up to properly check that those objects are no\nlonger alive.\n\nUnit tests have been added for this case with both of those as well as\nfile attachments, which didn't have this same problem because of the way\nwe calculate the file attachment state.\n\nTesting Done:\n- Ran unit tests.\n- Published a new review request that included a diff and saw that my\n  diff wasn't immediately deleted.\n\nReviewed at https://reviews.reviewboard.org/r/13905/","shortMessageHtmlLink":"Fix over-eager deletion with drafts."}},{"before":"da15d94c590ac080db6a18e1347cf9829221cd2e","after":"7884d78320ad2f9d8ab7ab893cbc739f5c8f9531","ref":"refs/heads/release-7.x","pushedAt":"2024-05-29T05:12:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix auth page description text color in dark mode.\n\nAuthentication pages were hard-coding a color for paragraph text in the\nauth header. This wasn't noticible on most of the auth pages, because\nwhen people are logged out, we show the default light theme. For\nweb-based RBTools authentication, we do have pages that the user could\nsee in dark mode. This change fixes it to use the `--ink-p-fg-weak`\ncolor instead.\n\nTesting Done:\nWas able to see description text for the web-based login pages.\n\nReviewed at https://reviews.reviewboard.org/r/13894/","shortMessageHtmlLink":"Fix auth page description text color in dark mode."}},{"before":"cafe4e13f133f0f135240186ec38b56f3b66e74e","after":"da15d94c590ac080db6a18e1347cf9829221cd2e","ref":"refs/heads/release-7.x","pushedAt":"2024-05-28T19:32:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Merge branch 'release-6.x' into release-7.x","shortMessageHtmlLink":"Merge branch 'release-6.x' into release-7.x"}},{"before":"f680802a68f6f73172e782ff8a96958815c2f95e","after":"a4c946aa4fa608ff419ee1f8c09f6660653a3933","ref":"refs/heads/release-6.x","pushedAt":"2024-05-28T19:32:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix installing Perforce in Docker.\n\nThe logic added to install Perforce in Docker didn't work correctly, for\na couple of reasons.\n\nFirst, we were basing our logic off of the build machine's architecture,\nnot the target architecture. When cross-building for X86 on ARM, we\nwouldn't even try to install Perforce support at all. We needed to base\nthings off of `$TARGETARCH` instead of `$BUILDARCH`.\n\nThat didn't even matter though, as we never declared we needed that\nvariable. So we skipped the Perforce support in all cases.\n\nAnd finally, even if that did work, we had the wrong command for\ninstalling the p4 support. And we had some bash-isms that didn't work in\nthe shell used to execute these commands.\n\nWe now declare and use `$TARGETARCH` for the comparisons, and properly\ninstall the `p4` binary and `p4python` support whenever we're building\nfor X86.\n\nNote that we can't build for ARM, as `p4python` still hasn't been\nreleased for ARM.\n\nTesting Done:\nBuilt for both ARM and X86, and checked the resulting P4 support in\nboth. Verified that we had it installed properly in X86, and didn't\nhave any of it in ARM.\n\nReviewed at https://reviews.reviewboard.org/r/13897/","shortMessageHtmlLink":"Fix installing Perforce in Docker."}},{"before":"61bbac75b51a19abc238c76a56bf9599a3fa08de","after":"cafe4e13f133f0f135240186ec38b56f3b66e74e","ref":"refs/heads/release-7.x","pushedAt":"2024-05-28T19:31:34.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode and modern tabs to the text and Markdown review UI.\n\nThe text review UI has been updated to support dark mode styling. The\ntext content already supported dark mode, but the custom tabs and the\noverridden styles for the filename header did not.\n\nWe now use `rb-c-tabs` for the tabs, helping that fit in with much of\nthe UI. We also use the default diff viewer header styling that we\ninherit for the filename information.\n\nTabs had to be updated to ensure we correctly override the `color` and\n`text-decoration` for the label, in case `<a>` is used (which is the\ncase here).\n\nWith this, we now have full dark mode support for text and Markdown\nreview.\n\nTesting Done:\nTested in light and dark modes with single revisions, diffs, plain\ntext, and Markdown files.\n\nReviewed at https://reviews.reviewboard.org/r/13890/","shortMessageHtmlLink":"Add dark mode and modern tabs to the text and Markdown review UI."}},{"before":"579be64300f4fda182b0bd9515cebb2f2b6b5b19","after":"61bbac75b51a19abc238c76a56bf9599a3fa08de","ref":"refs/heads/release-7.x","pushedAt":"2024-05-25T22:00:29.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Define resource data for all existing BaseResource subclasses.\n\nRecent changes to the BaseResource implementation made it so we define\nboth the attributes and the API response types. This change adds\ninterfaces for the response data for those existing BaseResource\nsubclasses that didn't have them.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13896/","shortMessageHtmlLink":"Define resource data for all existing BaseResource subclasses."}},{"before":"d0e6a04f775c88445e0ce7479b7feeea1adf2a75","after":"d57f04f0a3709f3793341fe6695226404af92245","ref":"refs/heads/master","pushedAt":"2024-05-25T17:26:50.000Z","pushType":"push","commitsCount":83,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Merge branch 'release-7.x'","shortMessageHtmlLink":"Merge branch 'release-7.x'"}},{"before":"86409cc55f91f036b54fbe4ea549676fef8bbbb3","after":"579be64300f4fda182b0bd9515cebb2f2b6b5b19","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T23:00:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Remove listKey from ReviewReply prototypeAttrs.\n\nThe listKey is now in BaseResource's prototypeAttrs, so this can go\naway.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13882/","shortMessageHtmlLink":"Remove listKey from ReviewReply prototypeAttrs."}},{"before":"84364096641ee68924c438362faba6dcf23d9725","after":"86409cc55f91f036b54fbe4ea549676fef8bbbb3","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T15:43:11.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Improve a lot of typing for BaseResource.\n\nThe BaseResource implementation in TypeScript had (and continues to\nhave) a number of issues. A lot of this stems from just bad design\ndecisions that were made before we even thought too much about typing or\npolymorphism, but some of it is just mistakes or poor understanding of\nTypeScript when I first converted it.\n\nThis change does the following:\n\n1. Switches the order of `TOptions` and `TExtraOptions`. I had followed\n   what `Backbone.Model` did, but didn't realize that the spina\n   `BaseModel` swaps them. This was making it so our call to\n   `CombinedModelConstructorOptions` was creating errors.\n2. Adds a base resource data interface, and extends that for subclasses\n   that currently define the resource data structure.\n3. Moved `payloadFileKeys` into the BaseResource implementation. This was\n   currently only defined in FileAttachment, but it's used inside of\n   BaseResource and by other (not-yet-typescriptified) subclasses.\n4. Changed `validate` to take in a `Partial<TDefaults>` instead of\n   `TDefaults`, which matches our usage of this method.\n5. Added type labels for everything that's in `prototypeAttrs` as\n   instance members too. This shuts up the type checker about these\n   magical properties.\n6. Properly passed in the attributes type for DraftReview.\n7. Added some missing type labels.\n\nChanges 1 & 2 are technically breaking, but the only class that was\naffected was `ReviewRequest`, and it seems highly unlikely that any\nthird-party code is using this yet, so I want to do it now.\n\nWhat this doesn't fix is our decision to override `fetch`, `save`, and\n`destroy` with incompatible signatures. I'm still puzzling over what to\ndo there to make it so we don't get huge horrible warnings about any\nresource class not being compatible with `Backbone.Model`.\n\nTesting Done:\nRan js-tests.\n\nReviewed at https://reviews.reviewboard.org/r/13847/","shortMessageHtmlLink":"Improve a lot of typing for BaseResource."}},{"before":"df18f007584e900e3cdce2f02ee6aef810c67c2f","after":"84364096641ee68924c438362faba6dcf23d9725","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T05:23:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix the default background color for review request infobox summaries.\n\nThe recent work on the review request infobox missed updating the\nbackground color for the summary area when there weren't any issues or\nShip Its. This was showing up as white on bright grey.\n\nWe now use a much more appropriate background color, a dark grey, a\nshade or two lighter than the background of the infobox itself. This is\nfar more readable and better fits the UI.\n\nTesting Done:\nTested the infobox in light and dark modes, with and without Ship Its and\nopen issues.\n\nReviewed at https://reviews.reviewboard.org/r/13880/","shortMessageHtmlLink":"Fix the default background color for review request infobox summaries."}},{"before":"edb1cf321cd6d7d8f78e90cf99be99c63c210525","after":"df18f007584e900e3cdce2f02ee6aef810c67c2f","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T05:00:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix the display of diff errors in dark mode.\n\nDiff errors had a white-on-yellow background on dark mode, due to using\na hard-coded background color and the default text color.\n\nWe now use the text-on-light color, and the warning alert color for the\nbackground. This matches the warning alert style we use elsewhere, which\nis designed to be quite noticeable on light and dark modes.\n\nTesting Done:\nTested diff errors on both dark and light modes.\n\nReviewed at https://reviews.reviewboard.org/r/13879/","shortMessageHtmlLink":"Fix the display of diff errors in dark mode."}},{"before":"e8640c7d2ad04ce9b34772385f83686835954abd","after":"edb1cf321cd6d7d8f78e90cf99be99c63c210525","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T04:51:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add a component class for comment thumbnails, with dark mode support.\n\nWe had multiple places were we were styling comment thumbnails. Both\nreviews and the review dialog had their own variants on a structure for\nthese, with different styling, and those styles had hacks that made dark\nmode support difficult to properly add.\n\nIn an effort to make this more maintainable, and to add dark mode, we\nnow have a new CSS component called `rb-c-review-comment-thumbnail`,\nwhich is responsible for styling the thumbnail area for a comment. This\nincludes the header (usually a filename and revision) and any thumbnail\ncontents (an image, part of a document, or a diff).\n\nThere are still hacks involved. In particular, we still treat diffs\nspecially. Instead of providing its own header, this component uses the\ndiff's filename header. It also works with the expand-controls-on-hover\nlogic, when opted into. This all involves some special structure and\nrules specific to diffs. However, we still benefit from having all of\nthis nicely grouped together with the base header and content styles,\nand all in one component instead of scattered throughout other CSS\nfiles.\n\nStyling has also been fixed up for some of the types of content we\nrender. Diffed text files, for instance, no longer attempt to override\nborders for everything. This will benefit the review UI as well.\n\nTesting Done:\nTested in light and dark mode for all comment types, both draft (in the\nReview Dialog) and published (in reviews).\n\nTested diff expansion in light and dark modes in both the Review Dialog\nand in published reviews.\n\nPython and JavaScript unit tests pass.\n\nReviewed at https://reviews.reviewboard.org/r/13854/","shortMessageHtmlLink":"Add a component class for comment thumbnails, with dark mode support."}},{"before":"a4a1a0c58c246c39ff35ad26daff7f324055f532","after":"e8640c7d2ad04ce9b34772385f83686835954abd","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T04:51:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Use dedicated URLs for accessing file attachment image-based thumbnails.\n\nWe recently introduced a new URL for accessing the contents of a file\nattachment, ensuring that cached page responses don't reference URLs\nthat can expire (such as those from S3). This was done for file\nattachments, but not for their thumbnails, which were susceptible to the\nsame problem.\n\nWe first noticed a symptom of this issue when moving\nhttps://reviews.reviewboard.org to expiring S3 URLs. Whenever we saved a\ncaption, we'd see the thumbnail reload. This was happening because we'd\nnotice the new URL with the new expiration in the metadata and\nre-generate the thumbnail information.\n\nNow, the download URL can accept a `?thumbnail=1&width=...` query\nparameter for accessing the thumbnail image for the attachment.  This\nrequires that the associated `MimetypeHandler` provides image thumbnail\ngeneration support (which `ImageMimetype` does).\n\nThere's a performance advantage here as well. Now, thumbnails are only\ngenerated on demand, when accessing the appropriate download URL. This\nmeans less work when first processing a file attachment, and potentially\nfewer things to delete when cleaning up.\n\nSince that's faster, we can now reference a @3x thumbnail for images\nwithout taking a performance penalty.\n\nTesting Done:\nUnit tests passed.\n\nVerified that thumbnails were continuing to work, and that editing\ncaptions was no longer causing a reload.\n\nVerified that thumbnail image files were only being generated for the\nDPI I was viewing with.\n\nReviewed at https://reviews.reviewboard.org/r/13870/","shortMessageHtmlLink":"Use dedicated URLs for accessing file attachment image-based thumbnails."}},{"before":"1c9502aa969866dc7cc9209f2a1a5c763e729787","after":"a4a1a0c58c246c39ff35ad26daff7f324055f532","ref":"refs/heads/release-7.x","pushedAt":"2024-05-21T04:48:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix overlapping elements in mobile mode for the datagrid filter.\n\nWhen viewing a datagrid in mobile mode, we were absolute-positioning the\nfilter dropdown to the right. This used to be fine, since we were\nrestricting the size of the title text, but the recent move to flexbox\nchanged that, resulting in the elements overlapping.\n\nFortunately, we can just take advantage of that flexbox and get rid of\nthe absolute positioning.\n\nTesting Done:\nTested the datagrid filter display at varying widths, making sure that\nwrapping was always correct.\n\nReviewed at https://reviews.reviewboard.org/r/13875/","shortMessageHtmlLink":"Fix overlapping elements in mobile mode for the datagrid filter."}},{"before":"4e1e8e8f8823c9544426e096bc204af116529837","after":"1c9502aa969866dc7cc9209f2a1a5c763e729787","ref":"refs/heads/release-7.x","pushedAt":"2024-05-18T22:17:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Bump jQuery and jQuery-UI versions.\n\nThis change bumps us up to the latest versions of jQuery and jQuery-UI.\nWhile we didn't actually have any exposure, the versions that we had\nbeen using were triggering alerts from various security scanning tools.\n\nWith this, we also now load jQuery-UI from `node_modules` instead of\nvendoring it into our source tree.\n\nThe one thing that I hit was some changes with the timing of the\n`remove` event causing a callback to hit after tests had already cleaned\nup the DnDUploader instance.\n\nTesting Done:\n- Ran npm install.\n- Ran js-tests.\n- Verified that autocomplete, modal dialogs, and dragging the comment\n  dialog still worked correctly.\n\nReviewed at https://reviews.reviewboard.org/r/13860/","shortMessageHtmlLink":"Bump jQuery and jQuery-UI versions."}},{"before":"4ae53f434c9f18b7b90d79efe256d199181930c7","after":"4e1e8e8f8823c9544426e096bc204af116529837","ref":"refs/heads/release-7.x","pushedAt":"2024-05-14T15:46:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Add documentation for the Microsoft Teams integration.\n\nThis adds documentation for the new Microsoft Teams integration.\n\nBased on work by Hailan Xu (/r/11302).\n\nTesting Done:\nBuilt the docs and tested that all the links are correct.\n\nReviewed at https://reviews.reviewboard.org/r/13776/","shortMessageHtmlLink":"Add documentation for the Microsoft Teams integration."}},{"before":"99ca6f01381532462ca498b66f08023a78c458a8","after":"4ae53f434c9f18b7b90d79efe256d199181930c7","ref":"refs/heads/release-7.x","pushedAt":"2024-05-09T06:00:13.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Update the dashboard bulk action dialogs to use Ink buttons.\n\nThis updates the bulk close and mute dialogs to use Ink buttons instead\nof `input`-based buttons, which also gives us better support in dark\nmode.\n\nTesting Done:\nTested bulk-muting/unmuting, bulk-archiving/unarchiving, and bulk-closing\nof review requests, in light and dark modes.\n\nReviewed at https://reviews.reviewboard.org/r/13843/","shortMessageHtmlLink":"Update the dashboard bulk action dialogs to use Ink buttons."}},{"before":"253fe9accd38ad8da2a36a7c32128b1563858e63","after":"99ca6f01381532462ca498b66f08023a78c458a8","ref":"refs/heads/release-7.x","pushedAt":"2024-05-09T05:58:30.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Add dark mode support for file thumbnails and improve overall styling.\n\nThis introduces dark mode styling for the file attachment thumbnails,\nhelping them fit in on the review request page and addressing the\ninvisible text issue that would occur.\n\nAlong with that, some interaction issues have been addressed. There were\ntwo issues in our styling:\n\n1. When editing a caption, the caption area and actions area didn't feel\n   seamless, as they were semi-transparent and had some overlaps that\n   looked strange. These are no longer semi-transparent during edit.\n\n2. When editing, moving the mouse over another thumbnail made the\n   thumbnail being edited semi-transparent, which didn't feel right. It\n   now stays at 100% opacity while in edit mode.\n\nTesting Done:\nTested the visuals for the file attachments in light and dark mode,\nincluding the caption area, empty captions, actions menu, and the\nunsaved caption indicator.\n\nTested editing the caption and then moving the mouse over another\nthumbnail. Verified that the file attachment did not fade out.\n\nReviewed at https://reviews.reviewboard.org/r/13837/","shortMessageHtmlLink":"Add dark mode support for file thumbnails and improve overall styling."}},{"before":"dc96ca4c5138eda9fb9e38ada940b618b3314005","after":"253fe9accd38ad8da2a36a7c32128b1563858e63","ref":"refs/heads/release-7.x","pushedAt":"2024-05-08T05:05:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix the updates bubble on dark mode and center the bubble.\n\nThe updates bubble has been updated to work correctly on dark mode. We\nstill use the same background color (utilizing the Ink warning alert\nbackground color), but the text and link colors are fixed to look\ncorrect on it.\n\nThe bubble is now centered horizontally, instead of off to the side.\nThis mirrors the design we've had in RBCommons for years, and helps keep\nthe bubble better in view on wide screens.\n\nTesting Done:\nTested on light and dark modes.\n\nReviewed at https://reviews.reviewboard.org/r/13829/","shortMessageHtmlLink":"Fix the updates bubble on dark mode and center the bubble."}},{"before":"1219b5b5c6128402815c11ba27bb8b21d0db1017","after":"dc96ca4c5138eda9fb9e38ada940b618b3314005","ref":"refs/heads/release-7.x","pushedAt":"2024-05-05T01:33:28.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"chipx86","name":"Christian Hammond","path":"/chipx86","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4063?s=80&v=4"},"commit":{"message":"Fix the color of field section labels for diffs in dark mode.\n\nThe Diff Revision, Commits, and Files section headers in the diff viewer\npage had a dark grey background, which conflicted with the background\nand didn't match the styling of the rest of the page.\n\nWe unfortunately don't have any standard classes for these that we can\ndepend on. This should be addressed, but not for this release, as it'd\nintroduce too many structural changes that aren't worth fixing up right\nnow.\n\nIn the meantime, we're now referencing the field label styling via CSS\nvariables. We're also using the proper font size for section labels,\nwhich is smaller than we had before, but more consistent with the rest\nof the page.\n\nTesting Done:\nTested the review request and diff viewer pages in light and dark mode,\nand compared the styling to the other section headers.\n\nReviewed at https://reviews.reviewboard.org/r/13823/","shortMessageHtmlLink":"Fix the color of field section labels for diffs in dark mode."}},{"before":"261ff4a341b1fdd19a4f6193eca636c8c27b614d","after":"1219b5b5c6128402815c11ba27bb8b21d0db1017","ref":"refs/heads/release-7.x","pushedAt":"2024-05-04T05:13:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Update package.lock for beanbag-frontend-buildkit bump.\n\nTrivial update to package.lock.","shortMessageHtmlLink":"Update package.lock for beanbag-frontend-buildkit bump."}},{"before":"5f0d50c0340e43c920b1a23375ec2b7b418193c4","after":"261ff4a341b1fdd19a4f6193eca636c8c27b614d","ref":"refs/heads/release-7.x","pushedAt":"2024-05-04T04:31:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up a bunch of lint issues.\n\nThis change fixes up a bunch of mostly-harmless linter errors. The vast\nmajority of these are unused imports or variable assignments that are\nnever used.\n\nTesting Done:\nRan unit tests.\n\nReviewed at https://reviews.reviewboard.org/r/13805/","shortMessageHtmlLink":"Fix up a bunch of lint issues."}},{"before":"1a38fe02b6c0f6e7d6b6b55837ca4035a8c72c2a","after":"5f0d50c0340e43c920b1a23375ec2b7b418193c4","ref":"refs/heads/release-7.x","pushedAt":"2024-05-03T16:26:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"davidt","name":"David Trowbridge","path":"/davidt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2240?s=80&v=4"},"commit":{"message":"Fix up a bunch of typos and misspellings.\n\nThis change fixes up the vast majority of typos and misspellings in our\ncodebase. The one non-false-positive hit that I've chosen not to change\nis the \"collapsable\" key in the diff chunks, since that data is stored\nin cache and might cause bad behavior after an upgrade.\n\nTesting Done:\n- Ran python tests.\n- Ran js tests.\n\nReviewed at https://reviews.reviewboard.org/r/13806/","shortMessageHtmlLink":"Fix up a bunch of typos and misspellings."}},{"before":"41053f2347f44fd6fcb1cdc0c831d79c61b7d4d9","after":"1a38fe02b6c0f6e7d6b6b55837ca4035a8c72c2a","ref":"refs/heads/release-7.x","pushedAt":"2024-04-30T14:27:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"michelle-aubin","name":"Michelle Aubin","path":"/michelle-aubin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46432749?s=80&v=4"},"commit":{"message":"Increase the max length for WebHookTarget's URL field.\n\nThis increases the max length for WebHookTarget's URL field from\n200 characters to 512.\n\nTesting Done:\n- Ran the evolution, with existing webhook targets in my DB.\n- Ran unit tests.\n- Tested adding/updating/deleting webhook targets.\n\nReviewed at https://reviews.reviewboard.org/r/13793/","shortMessageHtmlLink":"Increase the max length for WebHookTarget's URL field."}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWWblQQA","startCursor":null,"endCursor":null}},"title":"Activity · reviewboard/reviewboard"}