chore(docs): updated the name of Twitter to X #3066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The contributor profiles are auto generated. We can't change them |
mrgrain
requested changes
Oct 30, 2023
src/cdk/construct-lib.ts
Outdated
| @@ -23,7 +23,7 @@ export interface ConstructLibraryOptions extends JsiiProjectOptions { | |||
|
|
|||
| export interface Catalog { | |||
| /** | |||
| * Twitter account to @mention in announcement tweet. | |||
| * X account to @mention in announcement tweet. | |||
There was a problem hiding this comment.
Can you add something like (previously Twitter) to explain the difference in docs and property.
src/cdk/construct-lib.ts
Outdated
| * package name, description and the above link. You can disable these tweets | ||
| * through `{ announce: false }`. | ||
| * | ||
| * You can also add a Twitter handle through `{ twitter: 'xx' }` which will be | ||
| * You can also add a X handle through `{ X: 'xx' }` which will be |
There was a problem hiding this comment.
Suggested change
| * You can also add a X handle through `{ X: 'xx' }` which will be | |
| * You can also add a X handle through `{ twitter: 'xx' }` which will be |
This is an external API the can't changed unilaterally from here.
src/cdk/construct-lib.ts
Outdated
| @@ -7,11 +7,11 @@ export interface ConstructLibraryOptions extends JsiiProjectOptions { | |||
| * | |||
| * https://awscdk.io/packages/[@SCOPE/]PACKAGE@VERSION | |||
| * | |||
| * The catalog will also post a tweet to https://twitter.com/awscdkio with the | |||
| * The catalog will also post a tweet to https://x.com/awscdkio with the | |||
There was a problem hiding this comment.
Suggested change
| * The catalog will also post a tweet to https://x.com/awscdkio with the | |
| * The catalog will also post to https://x.com/awscdkio with the |
There was a problem hiding this comment.
Just wait a minute. I'm making the required changes.
|
@mrgrain |
mrgrain
requested changes
Oct 30, 2023
README.md
Outdated
| @@ -404,7 +404,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d | |||
| <td align="center" valign="top" width="14.28%"><a href="https://github.com/cogwirrel"><img src="https://avatars.githubusercontent.com/u/1848603?v=4?s=100" width="100px;" alt="Jack Stevenson"/><br /><sub><b>Jack Stevenson</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=cogwirrel" title="Code">💻</a></td> | |||
| <td align="center" valign="top" width="14.28%"><a href="https://github.com/jmourelos"><img src="https://avatars3.githubusercontent.com/u/3878434?v=4?s=100" width="100px;" alt="Jacob"/><br /><sub><b>Jacob</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=jmourelos" title="Code">💻</a></td> | |||
| <td align="center" valign="top" width="14.28%"><a href="http://joapy.com/"><img src="https://avatars3.githubusercontent.com/u/325306?v=4?s=100" width="100px;" alt="Jake Pearson"/><br /><sub><b>Jake Pearson</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=jakepearson" title="Code">💻</a></td> | |||
| <td align="center" valign="top" width="14.28%"><a href="http://twitter.com/bracki"><img src="https://avatars.githubusercontent.com/u/49786?v=4?s=100" width="100px;" alt="Jan Brauer"/><br /><sub><b>Jan Brauer</b></sub></a><br /><a href="https://github.com/projen/projen/commits?author=bracki" title="Code">💻</a></td> | |||
docs/api/API.md
Outdated
| @@ -15392,7 +15392,7 @@ Name | Type | Description | |||
| Name | Type | Description | |||
| -----|------|------------- | |||
| **announce**?🔹 | <code>boolean</code> | Should we announce new versions?<br/>__*Default*__: true | |||
| **twitter**?🔹 | <code>string</code> | Twitter account to.<br/>__*Optional*__ | |||
| **X**?🔹 | <code>string</code> | X account to.<br/>__*Optional*__ | |||
There was a problem hiding this comment.
This file shouldn't be changed manually, instead run the build. If you have to, see the build for the proper change.
mrgrain
requested changes
Oct 30, 2023
|
@mrgrain |
tvermaashutosh
changed the title
|
Build is still failing. |
|
@tvermaashutosh Are you still interested in finishing this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3065
Everyone must be well aware by now that the legal name of Twitter has been formally changed to X.
In this PR I have updated the name of Twitter to X in all the documentation (Texts and Links) of this repo.
Closes: reworkd/AgentGPT#1345
@mrgrain
Kindly review my PR and merge it please.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.