fix: Clearing a dashboard yaml stops updating errors #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
added
Type:Bug
nishantmonu51
approved these changes
May 17, 2024
AdityaHegde
force-pushed
the
adityahegde/errored-recovery-issue
branch
from
75eeedb
to
7679954
Compare
|
Pull some temporary changes from #4883 |
ericpgreen2
added a commit
that referenced
this pull request
May 20, 2024
* Patch recovery after errored entity * Use `setQueryData` rather than `refetchQueries` (which appears buggy) * Pull changes from another PR * Fix tsc --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely clearing a dashboard (cmd/ctrl + a and delete) and adding back something will stop showing any successive errors. This is reset after a refresh or opening some other file and coming back.
I think this is because we remove the resource query. Even resetting/refetching after that doesnt bring it back. A proper fix will follow but this is a hotfix for the release.
Might fix #4918