Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiline Operations / Multiline Selection #2601

Open
Semnodime opened this issue Feb 14, 2021 · 7 comments · May be fixed by #3323
Open

Multiline Operations / Multiline Selection #2601

Semnodime opened this issue Feb 14, 2021 · 7 comments · May be fixed by #3323
Labels
Enhancement Label requests for new features or to improve existing ones Refactoring This issue requires refactoring.

Comments

@Semnodime
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Sometimes an operation has to be applied on multiple lines of disassembled instructions.
Allowing for multiline selection and operating on those multiple lines can drastically eliminate redundant workload during binary analysis.

Describe the solution you'd like
Allow selection of multiple lines by drawing a rectange with the mouse (click-hold-move-release left mouse button).
Allow adding aditional individual lines by shortcut like Shift+Left Click.

Describe alternatives you've considered
Context menu entry for multiple line selection (not recommended due to unnecessarily nested UI actions).
@ITAYC0HEN ITAYC0HEN added Enhancement Label requests for new features or to improve existing ones Refactoring This issue requires refactoring. labels Feb 15, 2021
@karliss
Copy link
Member

karliss commented Feb 18, 2021

Related #1708 and the issue related to that.

@Semnodime Semnodime mentioned this issue Dec 18, 2021
Closed
@yasmiins
Copy link

Will be working on this issue with a team at Purdue as part of our senior design project.

@SantiagoTorres

@karliss
Copy link
Member

karliss commented Jan 16, 2024 •
edited

@yasmiins After you have familiarized yourself with existing code, before you get too deep into implementing stuff, I would appreciate if you posted a more detailed description of what and how you are planning to do for discussion. That way things will go much smoother once you reach the state of code review. Same applies to other issues.

@XVilka
Copy link
Member

XVilka commented Jan 16, 2024

@yasmiins I also recommend coming to our Mattermost "Cutter Dev" channel on https://im.rizin.re to have real time discussion with developers.

@yasmiins
Copy link

yasmiins commented Jan 17, 2024 •
edited

will do! @karliss @XVilka

@Rohan-Sagar
Copy link

I am part of the team working on this issue with Professor @SantiagoTorres

@XVilka @karliss @Semnodime Could you provide a demo to better understand the implementation and impact or should I just join Mattermost channel?

@XVilka
Copy link
Member

XVilka commented Feb 22, 2024

The biggest question here is, what operations (e.g. in context menu) would make sense for multiple instructions at the same time? @Semnodime what you had in mind for that?

The most sensible thing would be two operations

  • Define as data if it's code
  • Define as code if it's already data, or something like that.
  • Of course, copying the selected text/lines as well.
  • Is there anything else?

@yasmiins yasmiins linked a pull request Mar 25, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Label requests for new features or to improve existing ones Refactoring This issue requires refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add Multiline Selections/Operations yasmiins/cutter
6 participants
@XVilka @karliss @Semnodime @ITAYC0HEN @yasmiins @Rohan-Sagar