Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all esbuild's tests #938

Closed
10 tasks done
hyf0 opened this issue Apr 22, 2024 · 10 comments · Fixed by #1292
Closed
10 tasks done

Migrate all esbuild's tests #938

hyf0 opened this issue Apr 22, 2024 · 10 comments · Fixed by #1292
Assignees

Comments

@hyf0
Copy link
Member

hyf0 commented Apr 22, 2024


We need to try to run all the tests, and keep a diff of passed and failed in a snapshot. We need to make sure nothing hangs or crashes.

@hyf0
Copy link
Member Author

hyf0 commented Apr 22, 2024

bundler_css_test is not needed so far.

Tests related to typescript could be migrated but not passed due to we don't have builtn typescript transpile support. Others should be fine.

@chiehw
Copy link
Contributor

chiehw commented Apr 29, 2024

I'm confused about two place:

  1. why do some test folders start with dot?
  2. why do some test folders not have artifacts.snap file?

For example:
https://github.com/rolldown/rolldown/pull/984/files
image

@hyf0
Copy link
Member Author

hyf0 commented Apr 29, 2024

@chiehw https://rustdoc.swc.rs/testing_macros/attr.fixture.html#ignoring-a-test

@chiehw
Copy link
Contributor

chiehw commented Apr 29, 2024

ok, thanks. Why ignore these tests? a little curious. It seems that some test can be passed.

@hyf0
Copy link
Member Author

hyf0 commented Apr 29, 2024

ok, thanks. Why ignore these tests? a little curious. It seems that some test can be passed.

Mainly due to there aren't passed. If you find passed tests that are ignored, it's welcome to open a PR to enable them.

@zhusjfaker
Copy link
Collaborator

@hyf0
Copy link
Member Author

hyf0 commented May 29, 2024

https://github.com/evanw/esbuild/blob/main/internal/bundler_tests/bundler_loader_test.go

i will work it @hyf0 @IWANABETHATGUY

Thanks. The loader feature is complete yet. But you could start migrating these cases.

@IWANABETHATGUY
Copy link
Contributor

https://github.com/evanw/esbuild/blob/main/internal/bundler_tests/bundler_loader_test.go

i will work it @hyf0 @IWANABETHATGUY

You could use https://github.com/rolldown/rolldown/blob/main/scripts/misc/gen-esbuild-test.mjs, to auto-generated related tests.

@zhusjfaker
Copy link
Collaborator

@zhusjfaker
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants