Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cephfs + fscrypt in dev-env #14035

Open
NymanRobin opened this issue Apr 5, 2024 · 9 comments · May be fixed by #14199
Open

Add support for cephfs + fscrypt in dev-env #14035

NymanRobin opened this issue Apr 5, 2024 · 9 comments · May be fixed by #14199
Assignees
@NymanRobin
Labels
feature

Comments

@NymanRobin
Copy link
Contributor

NymanRobin commented Apr 5, 2024 •
edited

Change the common.yaml to reflect recent changes in ceph-csi and allow for custom Minikube VM image.

The current clusterroles in common.yaml for cephfs-csi-nodeplugin and cephfs-external-provisioner-runner do not, out of the box, support reading secrets and/or configmaps. This does not allow for the development of CephFS + fscrypt without patching this after starting the environment.

The chart changes have been made in the ceph-csi repository here. So, I think this could be done here as well?

However, to use CephFS + fscrypt, it requires a 6.6+ kernel version, and this is not something that Minikube offers out of the box. Therefore, it would be nice to also allow the possibility of setting the iso_url in the Minikube start command through environment variables.

EDIT: Setting the minikube iso is possible through environment variable export MINIKUBE_ISO_URL="[URL/FILE}"
@NymanRobin
Copy link
Contributor Author

Hey @parth-gr,

How does this sound and maybe a more general question if there is anyway standard how the common.yaml is kept in sync with the other repositories?

If this is something that sounds good, I could go ahead with the changes

@NymanRobin
Copy link
Contributor Author

Maybe @travisn would have some input on this?

@parth-gr
Copy link
Member

parth-gr commented Apr 24, 2024 •
edited

Yes @NymanRobin that would be a good idea.

It is also good to discuss them during the community meeting, https://github.com/rook/rook?tab=readme-ov-file#community-meeting

@NymanRobin
Copy link
Contributor Author

Good point, I will join the next community meeting @parth-gr

@iamniting
Copy link
Member

@NymanRobin Are you planning to add the permissions here in the common.yaml or shall I pick it up?

@NymanRobin
Copy link
Contributor Author

Sorry I have been busy with another "related" issue so forgot this one! Thanks for reminding me @iamniting, I will open a PR for this
/assign

@github-actions GitHub Actions
Copy link

Thanks for taking this issue! Let us know if you have any questions!

@parth-gr
Copy link
Member

@NymanRobin make sure to have a timeline plan for completion of this.

@NymanRobin NymanRobin linked a pull request May 14, 2024 that will close this issue
Open
@NymanRobin
Copy link
Contributor Author

I opened the PR now @parth-gr, let me know if it looks good!
For the minikube-iso I noticed it works simply by environment variable so no need to change anything,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NymanRobin NymanRobin

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

csi: add cephfs encryption support Nordix/rook
3 participants
@iamniting @parth-gr @NymanRobin