Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perform_job calls push_connection which is a deprecated function #1948

Open
PrenSJ2 opened this issue Jun 15, 2023 · 1 comment · May be fixed by #1949
Open

perform_job calls push_connection which is a deprecated function #1948

PrenSJ2 opened this issue Jun 15, 2023 · 1 comment · May be fixed by #1949

Comments

@PrenSJ2
Copy link

PrenSJ2 commented Jun 15, 2023 •
edited

in worker.py, the perform_job calls the function push_connection which raises a DeprecationWarning

should probs do this for pop_connection too
@PrenSJ2 PrenSJ2 linked a pull request Jun 15, 2023 that will close this issue
Open
@homeworkprod
Copy link
Contributor

I see various deprecation warnings in my test suite (with rq 1.15.1):

…/rq/connections.py:35: DeprecationWarning: The Connection context manager is deprecated. Use the `connection` parameter instead.
…/rq/connections.py:58: DeprecationWarning: The `push_connection` function is deprecated. Pass the `connection` explicitly instead.
…/rq/connections.py:72: DeprecationWarning: The `pop_connection` function is deprecated. Pass the `connection` explicitly instead.
…/rq/connections.py:87: DeprecationWarning: The `get_current_connection` function is deprecated. Pass the `connection` explicitly instead.
…/rq/connections.py:108: DeprecationWarning: The `resolve_connection` function is deprecated. Pass the `connection` explicitly instead.

Would be nice if rq itself wouldn't use them anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@homeworkprod @PrenSJ2