Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor standard lib exceptions over new classes needs clarification #690

Open
cwjenkins opened this issue Dec 9, 2017 · 1 comment
Open

Comments

@cwjenkins
Copy link

The following statement:
Favor the use of exceptions from the standard library over introducing new exception classes.
reads as if you should try not to introduce new exception classes where as in most projects you should.
It would be clearer if it was something like...
Favor the use of exceptions from the standard library versus reimplementing the same ones. Introduce new exception classes where the standard library doesn't provide what you need and ensure you namespace for your project.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 14, 2019

Yeah, I totally agree this can be worded better and examples can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants