Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a typo in the Suppressing Exceptions section? #887

Open
juanpaco opened this issue Oct 6, 2021 · 2 comments
Open

Is there a typo in the Suppressing Exceptions section? #887

juanpaco opened this issue Oct 6, 2021 · 2 comments

Comments

@juanpaco
Copy link

juanpaco commented Oct 6, 2021

At https://github.com/rubocop/ruby-style-guide#suppressing-exceptions, it says "Don't suppress" exceptions, but then lists do_something rescue nil as a good example.

# good
do_something rescue nil

It could be my ignorance, but that reads like an example of suppressing an exception. Am I misunderstanding? Apologies if so.

@pirj
Copy link
Member

pirj commented Oct 6, 2021

It indeed looks confusing.

It was originally introduced as a bad example, see 4240682#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R961

This is how bad turned good 3a20519

Would you like to add a brief explanation to why it's a good (fair use) example?
I can suggest digging through real-world-rails/real-world-ruby-apps for inspiration.

Here's an example of how it can look like:

# good - it's apparent what's going on

@juanpaco
Copy link
Author

juanpaco commented Oct 6, 2021

I'm definitely happy to help the project--- I'm struggling with my orthodoxy of not seeing rescue nil as acceptable in any case, heh. I'll need to come to terms with that. I'll browse in those examples.

I'm fine if you want to close the issue so that it doesn't add noise.

Thank you for the super fast and detailed response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants