Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe add post_create_command.sh to .devcontainer stuff to automate the codespaces a little more #49

Open
andrewm4894 opened this issue Oct 6, 2023 · 4 comments

Comments

@andrewm4894
Copy link

howdy - just watching the demo tutorial on YT (thanks!)

just wanted to mention - in case it could be helpful i think you could automate some of the dev setup steps in the devcontainer so that users would not need to manually run stuff like pyenv, poetry etc type stuff once the container is built.

you can use the post create command option in devcontainers to automate as much as possible.

here is an example of what i mean on another project i helped on a while back:

https://github.com/LAION-AI/Open-Assistant/blob/main/.devcontainer/backend-dev/post_create_command.sh

the .devcontainer for the backend-dev then just runs that script: https://github.com/LAION-AI/Open-Assistant/blob/709bb99d3e03dc62abc11892500352cb2da31a29/.devcontainer/backend-dev/devcontainer.json#L9

@andrewm4894
Copy link
Author

i might have a go at a pr to add this but just wanted to make the issue in case anyone else gets there first.

am 90% sure could be a useful addition (unless something i may be missing which of course is very much also possible :) )

@andrewm4894
Copy link
Author

i think you could even script up the env vars via gh secrets but that might be going too far maybe: https://docs.github.com/en/codespaces/managing-your-codespaces/managing-secrets-for-your-codespaces#using-secrets

@sourabhdesai
Copy link
Contributor

@andrewm4894 thanks a ton for that suggestion! I'm definitely looking for ways to improve the developer experience in terms of setup speed, so may actually look into this! Feel free to put up a PR if you have the time for one 🙌

@sourabhdesai
Copy link
Contributor

finally getting around to this! here's a PR with a post_create_command.sh script that does some additional setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants