Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to view images in the downloaded filings #61

Open
knandula opened this issue Oct 23, 2023 · 4 comments
Open

unable to view images in the downloaded filings #61

knandula opened this issue Oct 23, 2023 · 4 comments

Comments

@knandula
Copy link

knandula commented Oct 23, 2023

hey,

I watched the YouTube video https://www.youtube.com/watch?v=2O52Tfj79T4 and tried replicating the entire setup locally.
When I try to download sec filings using sec-edgar-downloader and then convert them to PDF - I don't see images being populated. HTML or. PDF files.

I'm guessing the downloader is picking up the name of the image asset and not appending or downloading the image assets.

Can someone help me understand this better? or how can I download the sec-filings including images?

@sourabhdesai

@sourabhdesai
Copy link
Contributor

@knandula thanks for raising this. Can you describe your setup? e.g. Windows, macOS, Linux? Did you install wkhtmltopdf?

Curious if you still see this issue if you're using the dev environment setup by our devcontainer config.

@knandula
Copy link
Author

@sourabhdesai I'm using MACOS and Github CodeSpaces.

wkhtmltopdf is installed as a dependency but still, I'm unable to see any images in the .htm version as well as the .pdf version.

@knandula
Copy link
Author

in the project we are use sec-edgar-download to download a filing and save it to the local folder.

https://github.com/jadchaar/sec-edgar-downloader/blob/4e5d1006c63c441c1ac467dd9e5b016d66aab3a6/sec_edgar_downloader/_orchestrator.py#L45

A clear #TODO is talking about resolving Image URLs. So, I'm just trying to understand how you downloaded the filings with images. (HTML files) @sourabhdesai

@knandula
Copy link
Author

@sourabhdesai any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants