Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bitbucket cloud webhook secrets #3909

Open
1 task
derektamsen opened this issue Nov 1, 2023 · 3 comments 路 May be fixed by #4275
Open
1 task

Add support for bitbucket cloud webhook secrets #3909

derektamsen opened this issue Nov 1, 2023 · 3 comments 路 May be fixed by #4275
Labels
feature New functionality/enhancement

Comments

@derektamsen
Copy link

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

Bitbucket cloud recently launched support for webhook secrets. Atlantis should allow adding a webhook secret for bitbucket cloud events. This will add improved security for atlantis to ensure recieved hooks are actually from bitbucket cloud instead of just relying on ip allow lists.

Describe the solution you'd like

The existing Atlantis support for bitbucket server webhook secrets should be extended to bitbucket cloud. This should use the existing configuration options with --bitbucket-webhook-secret. Additionally, once the feature is implemented, the warnings in the documentation regarding bitbucket cloud not supporting webhook secrets should be removed.

Describe the drawbacks of your solution

n/a

Describe alternatives you've considered

n/a

@derektamsen derektamsen added the feature New functionality/enhancement label Nov 1, 2023
@rohitgit-web
Copy link

We are also facing same issue.

@almightyfoon
Copy link

The logic for the feature is already in the bitbucketserver client, it should be as simple as porting over the logic and removing the specific check in place to stop that.

@Alexx23
Copy link

Alexx23 commented Apr 24, 2024

BitBucket supports secrets in webhooks from October 2023.
BitBucket post: https://bitbucket.org/blog/enhanced-webhook-security

So please remove the error that appears when using the "--bitbucket-webhook-secret" flag. Error: --bitbucket-webhook-secret cannot be specified for BitBucket Cloud because it is not supported by BitBucket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants