Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of GTEST assertion wrappers #6477

Open
kifir23917 opened this issue May 5, 2024 · 1 comment
Open

Get rid of GTEST assertion wrappers #6477

kifir23917 opened this issue May 5, 2024 · 1 comment
Labels
enhancement

Comments

@kifir23917
Copy link
Member

kifir23917 commented May 5, 2024 •
edited

We have various wrappers for GTEST assertions in our codebase (like EngineTestHelper::assertRpm or assertEqualsM2).
When test fails it outputs reference to wrapper instead of the failed row in test.

It's not convenient so I would suggest to get rid of assertion wrapper.
@kifir23917 kifir23917 mentioned this issue May 5, 2024
Merged
@rusefillc
Copy link
Contributor

No doubt about assertEquals*!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rusefillc @kifir23917