Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build a CV on Windows (Expected linebreaks to be 'LF' but found 'CRLF') #323

Open
ripper234 opened this issue Jan 27, 2019 · 6 comments

Comments

@ripper234
Copy link

Case

Bug

Issue

I am trying to get Best Resume Ever to work on Windows, ran it straight from the box without editing the YML, and am getting many such errors from eslint:

Starting dev server...
i 「wdm」: wait until bundle finished:
(node:12024) DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead

ERROR Failed to compile with 40 errors 2:24:40 PM

error in ./src/App.vue

Module Error (from ./node_modules/eslint-loader/index.js):

http://eslint.org/docs/rules/linebreak-style Expected linebreaks to be 'LF' but found 'CRLF'
src\App.vue:8:17
export default {
^

http://eslint.org/docs/rules/linebreak-style Expected linebreaks to be 'LF' but found 'CRLF'
src\App.vue:9:16
name: 'app'

Info

  • Operating System: Windows 10
  • Node-Version: v8.11.4

Reproduce

Just git clone and run it under Windows

@PikminGuts92
Copy link

I'm having the same issue. I'm using Node v11.3.0 on Windows 10.

@kiramishima
Copy link

In .estlintrc.json change

"linebreak-style": [
      "error",
      "unix"
]

to

"linebreak-style": [
      "error",
      "windows"
]

:)

@wildapt01
Copy link

@kiramishima 's solution should work fine.
On the other hand, node-os.EOL could be used in a script to amend that EsLint rule depending on the OS. It would turn this OS-agnostic.

@salomonelli
Copy link
Owner

Please feel free to create a PR :)

@scotrod
Copy link

scotrod commented Jun 15, 2020

@kiramishima 's solution worked for me but I feel like this should be included in the readme file for Windows users.

@Riya123-code
Copy link

can i work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants