fix(typeEvlauator): handle rest on object splat operations #232
Conversation
sgulseth
force-pushed
the
fix/rest-object-splat
branch
2 times, most recently
from
8ef8b24
to
15ec7ac
Compare
|
Something looks a bit sketchy. Here we invoke the mapper multiple times: groq-js/src/typeEvaluator/typeEvaluate.ts Lines 124 to 128 in 15ec7ac But here we assume that it's only being called once per groq-js/src/typeEvaluator/typeEvaluate.ts Lines 165 to 167 in 15ec7ac
I'm not 100% sure what the right approach here is though. Maybe more usage of |
|
yess, this should probably be a concrete type with mapConcrete, will fix. Didn't think much about fixing other bugs than the one referenced 😅 |
|
@judofyr did another pass on comparing with mapped concrete type node |
sgulseth
force-pushed
the
fix/rest-object-splat
branch
from
70fcc00
to
8e46302
Compare
sgulseth
force-pushed
the
fix/rest-object-splat
branch
2 times, most recently
from
1558ef1
to
8992280
Compare
src/typeEvaluator/typeEvaluate.ts
Outdated
| const attributes: Record<string, ObjectAttribute> = {} | ||
|
|
||
| const concreteNode = mapConcrete(node, scope, (node) => node) | ||
| if (concreteNode.type === 'object') { |
There was a problem hiding this comment.
Hmm. Doesn't this mean that if this returns false we end up returning {type: 'object', attributes: {}} below? What about we instead wrap all of this in mapConcrete?
return mapConcrete(node, scope, (node) => {
if (node.type !== 'object') return {type: 'unknown'}
const attributes: Record<string, ObjectAttribute> = {}
// same same…
})There was a problem hiding this comment.
I did another pass, moved the handling of the object splats out in its own methods
sgulseth
force-pushed
the
fix/rest-object-splat
branch
from
8992280
to
96bc3e7
Compare
sgulseth
force-pushed
the
fix/rest-object-splat
branch
from
fa78ba0
to
05e70bc
Compare
When splatting an object we didn't map over the rest property, if it's an object we should append the attributes. If
restis unknown we should treat the entire object as unknown.Fixes sanity-io/sanity#6555