Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation #1

Open
sargant opened this issue Dec 1, 2021 · 1 comment
Open

Validation #1

sargant opened this issue Dec 1, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sargant
Copy link
Owner

sargant commented Dec 1, 2021

It's a completely naive implementation at the moment, with zero validation.

Some thoughts on what validation could encompass:

  • Ensuring athlete IDs conform to /^A[0-9]+$/
  • Ensuring athlete name and ICE contact name aren't blank
  • Ensuring the ICE contact number is exactly that, a number
  • Providing a default value of "None" for medical info if the default is cleared

Also - should validation be done on both client & server, or server only? As the pass is retrieved by redirecting to a different URL, we can render a different page with an error message instead.
@sargant sargant added the enhancement New feature or request label Dec 1, 2021
@sargant
Copy link
Owner Author

sargant commented Dec 2, 2021

Partially implemented by #9 and #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sargant