Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference docs don't explain givens with ConstrApp #19016

Open
bjornregnell opened this issue Nov 21, 2023 · 0 comments · May be fixed by #20327
Open

reference docs don't explain givens with ConstrApp #19016

bjornregnell opened this issue Nov 21, 2023 · 0 comments · May be fixed by #20327
Labels
area:documentation good first issue Perfect for someone who wants to get started contributing itype:bug

Comments

@bjornregnell
Copy link
Contributor

Compiler version

3.3.1

Minimized code

This way of writing givens is a bit surprising:

given ops1: IntOps()

which perhaps is a shorthand for

given ops1: IntOps with {}

Expectation

An explanation and example of the usage of given IntOps() should be given here:
https://github.com/lampepfl/dotty/blob/main/docs/_docs/reference/contextual/givens.md
@bjornregnell bjornregnell added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Nov 21, 2023
@bjornregnell bjornregnell mentioned this issue Nov 21, 2023
Merged
@szymon-rd szymon-rd added area:documentation good first issue Perfect for someone who wants to get started contributing and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Nov 27, 2023
@som-snytt som-snytt linked a pull request May 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:documentation good first issue Perfect for someone who wants to get started contributing itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supplement structural givens doc som-snytt/dotty
2 participants
@bjornregnell @szymon-rd