Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle cyclic-reference type errors when using best-effort compilation options #20343

Open
jchyb opened this issue May 6, 2024 · 0 comments
Assignees
Labels
area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` itype:enhancement

Comments

@jchyb
Copy link
Contributor

jchyb commented May 6, 2024

Compiler version

main

Expectation

Currently best-effort compilation does not gracefully handle cyclic-reference type errors. Instead we recognize crashes caused by unpicking them as an unsuccessful best-effort compilation on an IDE side. Additionally any best-effort crash in a vulpix test suite should show a message with a way to disable the best-effort test on CI.
Unpickling cyclic-reference types however crash with StackOverflow errors which makes the CI fix message not show, causing friction to compiler contributors.
Ideally we want to replace any part of cyclic-reference crash with a ErrorType, so that the file can be freely pickled and unpicked. We don't want to do it in typer, so perhaps let's add another phase (triggered only with -Ybest-effort, after erroring in typer) after that to recognize and replace cyclic-reference types.

@jchyb jchyb added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels May 6, 2024
@jchyb jchyb self-assigned this May 6, 2024
@jchyb jchyb added itype:enhancement area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` and removed itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:best-effort-compilation Anything concerning `.betasty`, `-Ybest-effort` and `-Ywith-best-effort-tasty` itype:enhancement
Projects
None yet
Development

No branches or pull requests

1 participant