Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite shortened type printer to use refined / plain printer methods #20375

Open
rochala opened this issue May 10, 2024 · 0 comments
Open

Rewrite shortened type printer to use refined / plain printer methods #20375

rochala opened this issue May 10, 2024 · 0 comments
Assignees
@rochala
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug

Comments

@rochala
Copy link
Contributor

rochala commented May 10, 2024

Compiler version

3.5.0

Minimized code

Shortened type printer has a technical debt of custom methods handling printing of signatures.
This causes a lot of problems with label printing. This should be rewritten to reuse methods provided by RefinedPrinter / PlainPrinter such as showDcl

https://github.com/scala/scala3/blob/4bd33693ba759fe67437117f77bf6e5ddf3b7cf0/presentation-compiler/src/main/dotty/tools/pc/printer/ShortenedTypePrinter.scala
@rochala rochala added itype:bug area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels May 10, 2024
@rochala rochala self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rochala rochala

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rochala