Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry API client popup #1751

Closed
edorgeville opened this issue May 15, 2024 · 8 comments
Closed

Blurry API client popup #1751

edorgeville opened this issue May 15, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@edorgeville
Copy link

edorgeville commented May 15, 2024

What happens?

After upgrading scalar/fastify-api-reference to 1.22.38, the new API client popup stays blurry after finishing its animation.
Interestingly, toggling the device toolbar in devtools (Ctrl+Shift+M) seems to be doing something right, making everything sharp again. Possibly hardware acceleration related?

chrome_gYiRFWppDy.mp4

(the video doesn't carry well the blurriness, unfortunately...)

I think #1720 attempted to fix the issue but the issue remains.

What did you expect to happen?

No blur 🔍

How can we reproduce the issue?

Windows 10 22H2, Chrome 124.0.6367.158

Swagger/OpenAPI Example

No response

@edorgeville edorgeville added the bug Something isn't working label May 15, 2024
@cameronrohani
Copy link
Contributor

cameronrohani commented May 15, 2024

Hey @edorgeville I took another stab at it

#1752

would you be able to check out the preview deploy and let me know if this fixes it?

I haven't been able to replicate it on my end

Link to preview deploy: https://8b6c3e48-888b-432d-bd26-153737bd2fd9--scalar-deploy-preview.netlify.app/

@edorgeville
Copy link
Author

Still blurry here. It definetly comes from the transform: translate3d animation, toggling it on/off goes blurry / crisp. I'll keep digging on my side as well as reproduction is going to be a pain 😅

@cameronrohani
Copy link
Contributor

thanks so much for looking in to this @edorgeville

Let's remove the transform for the time being:

#1753

@edorgeville
Copy link
Author

edorgeville commented May 15, 2024

You're not going to be happy... it's still blurry!
But I got something more now:

chrome_N2cioMEmHN.mp4

(put the video in fullscreen, squint a bit, and focus at "Create user" in the top left)
I think the use of percentages causes the blur.

@cameronrohani
Copy link
Contributor

Okay let's change the way I position the pop up! Will ping you when I have a PR ready

@cameronrohani
Copy link
Contributor

@edorgeville check the preview let me know if this fixes it 🤞

https://2d8652d9-3e37-41a0-adfb-1ee529825f98--scalar-deploy-preview.netlify.app/

@edorgeville
Copy link
Author

You nailed it! Not blurry anymore.
I see #1753 has been merged, I'll close the current issue after testing the next release 🚀

@edorgeville
Copy link
Author

Just tested with "@scalar/fastify-api-reference": "^1.22.43", the issue is fixed. Thank you Cameron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants