Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Instruction Change: xc.aessub enc rot #78

Open
phthinh opened this issue Dec 6, 2018 · 1 comment
Open

Instruction Change: xc.aessub enc rot #78

phthinh opened this issue Dec 6, 2018 · 1 comment
Assignees
Labels
implementation Issue relates to the hardware implementation of the iSE software Issue relates to the example software or modified binutils. specification Issue relates to the XCrypto ISE specification verification Issue relates to the verification environment
Milestone

Comments

@phthinh
Copy link
Member

phthinh commented Dec 6, 2018

It should be more useful if this xc.aessub.encrot performs SBOX and byte right rotation instead of left rotation. So that, it can be used effectively in key expansion function.

@danpage
Copy link
Member

danpage commented Dec 10, 2018

I just checked through this, and I think you're right: it seems the mismatch might have stemmed from the fact the original paper used a big-endian, SPARC-based platform. So their left-rotate should be a right-rotate for a little-endian RISC-V?

@ben-marshall ben-marshall transferred this issue from scarv/xcrypto Feb 6, 2019
@ben-marshall ben-marshall transferred this issue from scarv/xcrypto-spec Dec 12, 2019
@ben-marshall ben-marshall added specification Issue relates to the XCrypto ISE specification verification Issue relates to the verification environment implementation Issue relates to the hardware implementation of the iSE software Issue relates to the example software or modified binutils. labels Dec 12, 2019
@ben-marshall ben-marshall added this to the XCrypto V2 milestone Dec 12, 2019
@ben-marshall ben-marshall changed the title instruction change proposal: xc.aessub enc rot Instruction Change: xc.aessub enc rot Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
implementation Issue relates to the hardware implementation of the iSE software Issue relates to the example software or modified binutils. specification Issue relates to the XCrypto ISE specification verification Issue relates to the verification environment
Projects
None yet
Development

No branches or pull requests

3 participants