-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error at telnet shutdown in Python 3 #2702
Comments
I'm using scrapy 1.3.3 with python 3.6.1, didn't see this while using the telnet console |
Fixes scrapy#2702 by only call self.port.stopListening() if self.start_listening() has already been called.
This would happen if the TelnetConsole was initialzed but never had its start_listening() method called because self.port is currently not defined in the former but is only defined in the latter. Fix proposed in #2892 |
Should we close this until there is a way to reproduce it? |
As discussed above, there is a way of reproducing it. Initialize the TelnetConsole but do not call its |
|
Class variables should always be initialized in the `.__init__()` method but `TerminalConsole.port` is not. As discussed in: * scrapy#2702 * scrapy#2892
@cclauss My understanding is that the original issue was triggered without manually interacting with the |
The original request was:
I broke that down into two requests:
That was #2892
That was #6224 If you do not want questions answered then please refrain from opening issues. |
Scrapy version:
I've got this exception on shutdown:
Not sure if it is a real problem, but it'd be nice to shut down without error messages. No idea how to reproduce it, I've only seen it once.
The text was updated successfully, but these errors were encountered: