Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6342. Setting METAREFRESH_IGNORE_TAGS to [‘noscript’] by default #6347

Merged
merged 4 commits into from May 10, 2024

Conversation

aisha-partha
Copy link
Contributor

@aisha-partha aisha-partha commented May 8, 2024

Setting METAREFRESH_IGNORE_TAGS to [‘noscript’] by default

Fixes #6342

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (c9bac7a) to head (180bc9b).
Report is 2 commits behind head on master.

❗ Current head 180bc9b differs from pull request most recent head fe163d9. Consider uploading reports for the commit fe163d9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6347       +/-   ##
===========================================
+ Coverage   43.78%   85.00%   +41.21%     
===========================================
  Files         161      161               
  Lines       11962    11962               
  Branches     1872     1872               
===========================================
+ Hits         5238    10168     +4930     
+ Misses       6355     1512     -4843     
+ Partials      369      282       -87     
Files Coverage Δ
scrapy/settings/default_settings.py 98.80% <100.00%> (ø)

... and 142 files with indirect coverage changes

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wRAR wRAR merged commit 10a843a into scrapy:master May 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set METAREFRESH_IGNORE_TAGS to ["noscript"] by default
3 participants