Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certain args of ScrapyAgent and TunnelingAgent required #6343

Closed
wRAR opened this issue May 7, 2024 · 1 comment · Fixed by #6349
Closed

Make certain args of ScrapyAgent and TunnelingAgent required #6343

wRAR opened this issue May 7, 2024 · 1 comment · Fixed by #6349
Labels

Comments

@wRAR
Copy link
Member

wRAR commented May 7, 2024

scrapy.core.downloader.handlers.http11.ScrapyAgent and scrapy.core.downloader.handlers.http11.TunnelingAgent take some args (contextFactory in both and crawler in ScrapyAgent) that are currently declared optional but in fact need to be passed as the code assumes they aren't None. So ideally they should be declared as required (but that requires reordering args and/or making all args of those constructors keyword-only so there is no clear and simple fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants