-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scylla crash when reading from mutation fragments with token() filtering #18637
Labels
Backport candidate
backport/5.4
Issues that should be backported to 5.4 branch once they'll be fixed
Comments
auto schema = std::invoke([&] () -> schema_ptr {
if (receiver_cf.has_value() && db.has_schema(receiver_ks, *receiver_cf)) {
return db.find_schema(receiver_ks, *receiver_cf);
} else {
return nullptr;
}
}); checks |
xemul
added a commit
to xemul/scylla
that referenced
this issue
May 13, 2024
Getting token() function first tries to find a schema for underlying table and continues with nullptr if there's no one. Later, when creating token_fct, the schema is passed as is and referenced. If it's null crash happens. It used to throw before 5983e9e (cql3: test_assignment: pass optional schema everywhere) on missing schema, but this commit changed the way schema is looked up, so nullptr is now possible. fixes: scylladb#18637 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
xemul
added
the
backport/5.4
Issues that should be backported to 5.4 branch once they'll be fixed
label
May 13, 2024
mergify bot
pushed a commit
that referenced
this issue
May 15, 2024
Getting token() function first tries to find a schema for underlying table and continues with nullptr if there's no one. Later, when creating token_fct, the schema is passed as is and referenced. If it's null crash happens. It used to throw before 5983e9e (cql3: test_assignment: pass optional schema everywhere) on missing schema, but this commit changed the way schema is looked up, so nullptr is now possible. fixes: #18637 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com> (cherry picked from commit df8a446)
denesb
pushed a commit
that referenced
this issue
May 16, 2024
Getting token() function first tries to find a schema for underlying table and continues with nullptr if there's no one. Later, when creating token_fct, the schema is passed as is and referenced. If it's null crash happens. It used to throw before 5983e9e (cql3: test_assignment: pass optional schema everywhere) on missing schema, but this commit changed the way schema is looked up, so nullptr is now possible. fixes: #18637 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com> (cherry picked from commit df8a446) Closes #18698
xemul
added a commit
to xemul/scylla
that referenced
this issue
May 20, 2024
…ts() When selecting from mutation_fragments(table) one may want to apply token() filtering againts partition key. This doesn't work currently, but used to crash. This patch adds a regression test for that refs: scylladb#18637 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This was referenced May 20, 2024
xemul
added a commit
to xemul/scylla
that referenced
this issue
May 20, 2024
…ts() When selecting from mutation_fragments(table) one may want to apply token() filtering againts partition key. This doesn't work currently, but used to crash. This patch adds a regression test for that refs: scylladb#18637 Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport candidate
backport/5.4
Issues that should be backported to 5.4 branch once they'll be fixed
c8cc47d
decoded
The text was updated successfully, but these errors were encountered: