Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to add more metrics to the per-table-per-instance reporting #18642

Closed
amnonh opened this issue May 13, 2024 · 2 comments
Closed

Need to add more metrics to the per-table-per-instance reporting #18642

amnonh opened this issue May 13, 2024 · 2 comments
Assignees
@amnonh
Labels
Backport candidate backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed
Milestone
6.1

Comments

@amnonh
Copy link
Contributor

amnonh commented May 13, 2024

The following metrics are part of the dashboard, so they should be enabled per-instance by default:
cache_hit_rate
latency
live_disk_space
@mykaul mykaul added this to the 6.1 milestone May 13, 2024
@amnonh
Copy link
Contributor Author

amnonh commented May 13, 2024

@mykaul it would be nice if it can make it to 6.0, I'm testing a patch now, it should be backported to 2024.1

@mykaul
Copy link
Contributor

mykaul commented May 13, 2024

If the PR is merged before 6.0 branches, it'll be there.

amnonh added a commit to amnonh/scylla that referenced this issue May 13, 2024
@amnonh
replica/table.cc: Add metrics per-table-per-node
bc3cc67 
This patch adds metrics that will be reported per-table per-node.
The added metrics (that are part of the per-table per-shard metrics)
are:
scylla_column_family_cache_hit_rate
scylla_column_family_read_latency
scylla_column_family_write_latency
scylla_column_family_live_disk_space

Fixes scylladb#18642

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
@amnonh amnonh mentioned this issue May 13, 2024
Closed
@mykaul mykaul added the backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed label May 15, 2024
mergify bot pushed a commit that referenced this issue May 15, 2024
@amnonh @mergify
replica/table.cc: Add metrics per-table-per-node
d6407d6 
This patch adds metrics that will be reported per-table per-node.
The added metrics (that are part of the per-table per-shard metrics)
are:
scylla_column_family_cache_hit_rate
scylla_column_family_read_latency
scylla_column_family_write_latency
scylla_column_family_live_disk_space

Fixes #18642

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
(cherry picked from commit bc3cc67)

# Conflicts:
#	replica/table.cc
@mergify mergify bot mentioned this issue May 15, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amnonh amnonh

Labels
Backport candidate backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed
Projects
None yet
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

replica/table.cc: Add metrics per-table-per-node amnonh/scylla
3 participants
@amnonh @mykaul @scylladb-promoter