replica/table.cc: Add metrics per-table-per-node #18645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds metrics that will be reported per-table per-node. The added metrics (that are part of the per-table per-shard metrics) are: scylla_column_family_cache_hit_rate scylla_column_family_read_latency scylla_column_family_write_latency scylla_column_family_live_disk_space Fixes scylladb#18642 Signed-off-by: Amnon Heiman <amnon@scylladb.com>
🟢 CI State: SUCCESS✅ - Build Build Details:
|
denesb
approved these changes
May 14, 2024
github-actions
bot
added
promoted-to-master
backport/5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous patches add per-table metrics reported per node (instead of per shard). Enabling table view for customers.
The per-node metrics reporting is on by default; this is why the number of metrics is limited.
This patch adds metrics that will be reported per table, per node. The added metrics (that are part of the per-table per-shard metrics) are:
scylla_column_family_cache_hit_rate
scylla_column_family_read_latency
scylla_column_family_write_latency
scylla_column_family_live_disk_space
And they are used by the keyspace/table dashboard.
Fixes #18642
No need to backport, it's part of 6.0