hinted handoff: Prevent segmentation fault when initializing endpoint managers #18650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawmd
added
type/bug
area/hinted handoff
piodul
reviewed
May 13, 2024
db/hints/manager.cc
Outdated
| @@ -873,11 +873,11 @@ future<> manager::perform_migration() { | |||
| const auto lock = co_await seastar::get_units(_drain_lock, 1); | |||
|
|
|||
| using lock_type = std::unique_lock<seastar::shared_mutex>; | |||
| // We're taking this lock because we're about to stop endpoint managers here, wheras | |||
| // We're taking this lock because we're about to stop endpoint managers here, whereas | |||
There was a problem hiding this comment.
Spelling fixes are no longer needed, they were fixed by #18567 which is already on master
If hinted handoff is still IP-based and there is a hint directory representing an IP without a corresponding mapping to a host ID in `locator::token_metadata`, an attemp to initialize its endpoint manager will result in a segmentation fault. This commit prevents that.
Before these changes, if initializing endpoint managers after the migration of hinted handoff to host ID is done throws an exception, we don't remove the flag indicating the migration is still in progress. However, the migration has, in practice, finished -- all of the hint directories have been mapped to host IDs and all of the nodes in the cluster are host-ID-based. Because of that, it makes sense to remove the flag early on.
|
Version 2:
|
piodul
approved these changes
May 13, 2024
🟢 CI State: SUCCESS✅ - Build Build Details:
|
|
Queued |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't attempt to create an endpoint manager for a hint directory if there is no mapping host ID–IP corresponding to the directory's name, an IP address. That prevents a segmentation fault.
Fixes #18649