Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for tests generating Semaphore proofs #761

Open
vplasencia opened this issue Apr 30, 2024 · 1 comment
Open

Increase timeout for tests generating Semaphore proofs #761

vplasencia opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working tests 🧪 Adding missing or correcting existing tests

Comments

@vplasencia
Copy link
Member

Description

There is an error when running the test workflow:

Proof › # generateProof › Should generate a Semaphore proof

    thrown: "Exceeded timeout of 20000 ms for a test.

https://github.com/semaphore-protocol/semaphore/actions/runs/8894821856/job/24423871569

@vplasencia vplasencia added bug 🐛 Something isn't working tests 🧪 Adding missing or correcting existing tests labels Apr 30, 2024
@vplasencia vplasencia self-assigned this Apr 30, 2024
@sripwoud
Copy link
Contributor

sripwoud commented May 3, 2024

There are 2 different issues in that test(s):

  • Timeout for the proof generation:
    Increasing timeout can probably fix it. But I think the root cause is related to Error in the production and pull-requests workflows privacy-scaling-explorations/zk-kit#280 (comment)
  • Structure of the test:
    Here
    We use a proof defined in the outer scope as parameter. It makes the tests depend on each others. As a result the test suite may produce unexpected results: a successful proof verification test requires the proof generation test having completed first, but jest executes everything in parallel...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working tests 🧪 Adding missing or correcting existing tests
Projects
None yet
Development

No branches or pull requests

2 participants