Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor share page to be a modal component #52

Open
kasumi-1 opened this issue Dec 15, 2023 · 5 comments
Open

refactor share page to be a modal component #52

kasumi-1 opened this issue Dec 15, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@kasumi-1
Copy link
Contributor

The separate page for /share is unnecessary and causes conversation state to be lost.
@kasumi-1 kasumi-1 added the enhancement New feature or request label Dec 15, 2023
@agrim0312
Copy link

hey @kasumi-1 can i work on this

@kasumi-1
Copy link
Contributor Author

@agrim0312 sure thing!

@agrim0312
Copy link

@kasumi-1 are you using any UI library or i need to build it from scratch using divs??

@kasumi-1
Copy link
Contributor Author

tailwind

@agrim0312 agrim0312 mentioned this issue Dec 17, 2023
Open
@agrim0312
Copy link

@kasumi-1 please check the PR and please guide me if any changes required as i am new to open source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kasumi-1 @agrim0312