Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Trim whitespace around font filenames. #32298

Merged
merged 1 commit into from
May 17, 2024

Conversation

mukilan
Copy link
Member

@mukilan mukilan commented May 16, 2024

This is a speculative fix for #32161. A similar failure is
reproducible on the Android x86_64 emulator with API 35
system image. The fix has not been validated on the actual
device, so potentially there might be other issues that need
to be fixed to complete #32161.

Signed-off-by: Mukilan Thiyagarajan mukilan@igalia.com


This is a speculative fix for servo#32161. A similar failure is
reproducible on the Android x86_64 emulator with API 35
system image. The fix has not been validated on the actual
device so potentially there might be other issues that need
to be fixed to complete servo#32161.

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also be worth printing the font file name so that we have more debugging information to go on.

@mukilan
Copy link
Member Author

mukilan commented May 16, 2024

It might also be worth printing the font file name so that we have more debugging information to go on.

Good idea. I'll raise a separate PR as this needs to done for Mac & Linux platforms as well.

@mukilan mukilan added this pull request to the merge queue May 17, 2024
Merged via the queue into servo:main with commit c9ab743 May 17, 2024
9 checks passed
@mukilan mukilan deleted the android-trim-font-filenames branch May 17, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on Android build
2 participants