Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Structure #5

Open
Drawaes opened this issue Jul 2, 2017 · 2 comments
Open

Project Structure #5

Drawaes opened this issue Jul 2, 2017 · 2 comments

Comments

@Drawaes
Copy link
Contributor

Drawaes commented Jul 2, 2017

I would recommend a move to using the "standard" .net project structure where you have a top level solution, and then a src, samples, test folders so that the entire codebase can be opened from one place.

If you are keen for that I am happy to do it via a PR when bored (didn't want to mess with the structure without asking first ;) )

@shanselman
Copy link
Owner

Good stuff! Can InstructionCollection be collapsed like Process was also? (I assume it still runs/works after this?)

Why does GitHub think that you changed everything? Whitespace issues?

@Drawaes
Copy link
Contributor Author

Drawaes commented Jul 4, 2017

Ahh because I moved and edited the files... maybe I should move.. commit and the edit the files... let me redo the PR I was a little surprised about that as well.
I also collapsed the other collection and removed the arraylists in favour of generics.
As far as "runs", all the samples run through but without any result tests it's a bit hard to tell correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants