Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 17: Feature requests, please add in comments #48

Open
shaps80 opened this issue Jun 6, 2023 · 23 comments
Open

iOS 17: Feature requests, please add in comments #48

shaps80 opened this issue Jun 6, 2023 · 23 comments

Comments

@shaps80
Copy link
Owner

shaps80 commented Jun 6, 2023

In order to best serve the community, please request features (or react to an existing one) using the comments on this issue. I will then prioritise all efforts to try and fill those backports where possible 👍

For Swift (non-UI) requests please see SwiftBackports

–––

I'm surprised I need to say this, but please do not add comments below that are unrelated to this ticket!

Repository owner deleted a comment from ShikiSuen Jun 7, 2023
@shaps80
Copy link
Owner Author

shaps80 commented Jun 7, 2023

  • Section expand/collapse
  • PhaseAnimator (in-progress)
  • KeyFrameAnimator
  • SensoryFeedback (in-progress)
  • #Preview

@yujinqiu
Copy link

backport symbolEffect will be appreciated

@shaps80
Copy link
Owner Author

shaps80 commented Jun 13, 2023

backport symbolEffect will be appreciated

I'm not sure this one is possible, but I may investigate to confirm 👍

@yujinqiu
Copy link

ContentUnavailableView is also useful and it looks not hard to backport.

@shaps80
Copy link
Owner Author

shaps80 commented Jun 15, 2023

ContentUnavailableView is also useful and it looks not hard to backport.

Hadn't seen that, feel free to submit a PR if its easy 👍

That being said, I'm guessing its a bit more involved to support all platforms correctly, and also I'm guessing its locale aware.

I wonder how many people will actually use this tbh, simply cause it would be off-brand for many apps.


Hmmm I just tested it out and I'm surprised it's limited to search (for built-in API) and also doesn't appear to be locale-aware by default. Honestly not sure if this adds much value, surprised it's included. But you're right, looks super easy to backport, feel free please 👍

@PangMo5
Copy link

PangMo5 commented Jun 19, 2023

scrollTarget(isEnabled:), scrollTargetBehavior(_:), scrollTargetLayout(isEnabled:)
It would be really useful if those methods were backported.

@shaps80
Copy link
Owner Author

shaps80 commented Jun 19, 2023

@PangMo5 I agree! I'll need to dig into these in details, I did take a very quick look a while ago and thought perhaps this couldn't be done, but I'll need to get into the weeds before I know for sure 👍

@BastianKusserow
Copy link

A backport of .contentTransition(.numericText(value:)) would be awesome!

@shaps80
Copy link
Owner Author

shaps80 commented Aug 30, 2023

A backport of .contentTransition(.numericText(value:)) would be awesome!

I considered this actually, I don't think it's that difficult to implement actually, could be done essentially with an AnimatableModifier I think – however I'd rather backport the entire contentTransition API vs just a specific version of it, and tbh not all of them are so easy AFAICT.

I'll consider it though 👍

@BastianKusserow
Copy link

@shaps80 would be interested on how you would implement the numeric text transition, as I've struggled with this quite a lot when I tried it. I thought one could reuse the numericText(countDown:) transition but I was not sure how I get the old and the new value for comparison..

@shaps80
Copy link
Owner Author

shaps80 commented Aug 31, 2023

@shaps80 would be interested on how you would implement the numeric text transition, as I've struggled with this quite a lot when I tried it. I thought one could reuse the numericText(countDown:) transition but I was not sure how I get the old and the new value for comparison..

Definitely dig into animatable modifier, it's not a quick response that I can leave here. And I just don't have the time right now to Explore. Sorry

@bstillitano
Copy link

searchScopes would be great to have back ported to at least iOS 15

@shaps80
Copy link
Owner Author

shaps80 commented Sep 8, 2023

@bstillitano good shout! I did actually start (unfinished) a searchable modifier backport when it was first released. I can't remember why I didn't finish it. I could try completing that and adding scopes as well as tokens actually cause that's a great API.

@vmanot
Copy link

vmanot commented Sep 18, 2023

@shaps80 would love to know if backporting Shader is even possible.

@shaps80
Copy link
Owner Author

shaps80 commented Sep 19, 2023

@vmanot that's def out of my scope tbh, but I'd be surprised if it wasn't possible at least 1 or 2 versions back. I'd definitely love a PR exploring this!

@vmanot
Copy link

vmanot commented Sep 20, 2023

@shaps80 glad to know there are no obvious reasons as to why not! And yes, will definitely PR if I find the bandwidth to push on this front.

@jadar
Copy link

jadar commented Sep 28, 2023

@shaps80 I'd be willing to take a crack at that searchable modifier backport, if you wanted to hand it off. :)

@shaps80
Copy link
Owner Author

shaps80 commented Oct 2, 2023

@shaps80 I'd be willing to take a crack at that searchable modifier backport, if you wanted to hand it off. :)

Sure! I have a start somewhere. Let me try and find it and see if I can drop a starting branch off.

If not I'll let you know and you can start off from scratch. Gimme a couple days.

@hstdt
Copy link

hstdt commented Dec 20, 2023

how about backport .buttonRepeatBehavior(.enabled)

@nlash-livly
Copy link

would love to have .scrollPosition(id:)

@futuretap
Copy link

would love to have UIViewRepresentable.sizeThatFits(_:uiView:context:) and View.contentMargins(_:for:).

@fl034
Copy link

fl034 commented Feb 5, 2024

TipKit would be awesome!

@shaps80
Copy link
Owner Author

shaps80 commented Feb 6, 2024

@fl034 I actually started a fairly full on backport of TipKit, but then I realised some issues. We'd equally need to backport the new Predicate APIs (including the macros) since its syntax heavily relies on that.

It's totally possible, especially since Predicate is actually open sourced through the Foundation efforts on Apple's repo. However it's a huge effort and I've simply not had the time to properly get into it.

I also, love TipKit and agree it'd be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests