Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Files removed from the repo but still presents in deploy #254

Open
Edo78 opened this issue Oct 11, 2019 · 1 comment
Open

Files removed from the repo but still presents in deploy #254

Edo78 opened this issue Oct 11, 2019 · 1 comment

Comments

@Edo78
Copy link

Edo78 commented Oct 11, 2019

Hi, I recently take over a project that use shipit for its own deploy and I never used.
The following versions are in use

"shipit-cli": "4.2.0",
"shipit-deploy": "4.1.4",
"shipit-npm": "0.2.0",
"shipit-utils": "1.4.1",

After a deploy I realized that on the server was deployed at least one file that was recently removed from the repo. I double checked the revision deployed and I even checked it out in a new directory to be sure it wasn't a glitch in git.

As a workaround I removed all the released version and proceeded with a brand new deploy.

It looks like it was a missing --delete option on rsync but I didn't even get if/where add this option to give it a shot.

I'm concerned about the next time I'll remove a file because removing the deployed versions didn't looks like a viable solution.

Is there something I can put in the configuration or should I update my shipt versions?

@Edo78
Copy link
Author

Edo78 commented Oct 14, 2019

I found out that I can set config.copy to false
This way shipit didn't perform a copyPreviousRelease and I'm free from old files that shouldn't exists (this is way they are removed from the repo).

To me this function is just a PITA but I'm probably missing something because if it's the default behaviour it should have some huge reason to be here.

Can you help me understanding the logic that require such default flow?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant