-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamma correction #111
Comments
@osman-turan Hi Osman, The current gamma correction code uses features in the But that said, if you'd like to work on your own function or make use of the logic in this, it's completely up to you! 😄 Thanks again for the help, it's greatly appreciated! |
Thanks for the details! Due to rounding, there might be some edge cases at my implementation. If you encounter such inputs, please let me know so that I can work on a fix. |
At planned features, the gamma correction is listed. At the same time, the codebase has a commented-out piece of code for gamma correction. See:
photon/crate/src/colour_spaces.rs
Lines 10 to 50 in 475562b
I haven't checked the correctness of the commented-out function. Why is it commented-out? What's the expectation and plan for the gamma correction? I can work on this feature if you like.
The text was updated successfully, but these errors were encountered: